More comprehensive error handling #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
more-comprehensive-error-handling
branch
from
d20203c to
e9ddd37
Compare
|
apata
force-pushed
the
more-comprehensive-error-handling
branch
from
7a3cd5b to
92fac22
Compare
|
1 similar comment
|
4 tasks
ukutaht
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, any error occurring within the route tree falls back to router's default error component, not to our ErrorBoundary.
Example: https://plausible.io/plausible.io?filters=invalid
This PR configures our custom error message to be shown for those errors as well.
Example: https://pr-4444.review.plausible.io/plausible.io?filters=1
It also slightly changes the styling of that error (the error is rendered with monospaced font), and provides a navigation suggestion to the user that might remedy the situation.
Tests
Changelog
Documentation
Dark mode