Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing framework #4440

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Add testing framework #4440

merged 2 commits into from
Aug 15, 2024

Conversation

apata
Copy link
Contributor

@apata apata commented Aug 13, 2024 •
edited
Loading

Changes

  • Removes invalid .js file extensions from some imports
  • Adds jest testing framework for /assets
  • Adds react testing library
  • Adopts FE testing principle of colocating the test with the module, not in a separate directory tree
  • Tests url module
  • Tests date picking logic
  • Adds test command to the CI

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Docs

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@apata apata force-pushed the testing-framework branch from 7be32c4 to 94c18f3 Compare August 13, 2024 18:27
aerosol
aerosol approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@aerosol aerosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@apata apata force-pushed the testing-framework branch 5 times, most recently from dd7191a to f281285 Compare August 14, 2024 13:39
@apata apata added the preview label Aug 14, 2024
@github-actions GitHub Actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4440

@apata apata force-pushed the testing-framework branch from f281285 to 4c952d0 Compare August 15, 2024 08:08
@apata apata merged commit 8af3f73 into master Aug 15, 2024
11 checks passed
@apata apata deleted the testing-framework branch August 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerosol aerosol aerosol approved these changes

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apata @aerosol