Unify and refactor login regardless of trigger source (explicit/register) #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
auth-refactor-redux2
branch
3 times, most recently
from
7a3bda1 to
97f75be
Compare
|
zoldar
force-pushed
the
auth-refactor-redux2
branch
from
97f75be to
44cf9bd
Compare
aerosol
approved these changes
Aug 14, 2024
zoldar
force-pushed
the
auth-refactor-redux2
branch
from
44cf9bd to
b0cd074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A pure refactor meant to slightly improve logic around login. Rate limiting is now applied more consistently as well.
Originally, I had a couple attempts at more extensive refactors but failed to come up with anything sensible. For now I'm settling for an incremental improvement.
Tests