Remove query and site props passing from everywhere except class components #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
alleviate-props-passing-further
branch
from
2f4a3f5 to
5fffacc
Compare
macobo
reviewed
Jul 11, 2024
| function MatchDayOfWeekInput({ history, query, site }) { | ||
| function MatchDayOfWeekInput({ history }) { | ||
| const site = useSiteContext() | ||
| const { query } = useQueryContext() |
There was a problem hiding this comment.
Would something like useDashboardContext() make sense which would encapsulate both site AND query? 🤔
There was a problem hiding this comment.
Thanks!
I considered it initially, but my hunch is that many of these components don't really need either.
I think the way forward is to actually remove some of these superfluous dependencies, and provide components with specific handlers for what they're supposed to do: in this example handleCompareExactMatch, handleCompareDayOfTheWeek.
Such handlers would be declared higher up in the React tree and themselves dependent on a shared API component, which is dependent on the site.domain.
macobo
reviewed
Jul 11, 2024
|
apata
force-pushed
the
alleviate-props-passing-further
branch
from
336a058 to
3195912
Compare
apata
added
deploy-to-staging
|
1 similar comment
|
|
apata
force-pushed
the
alleviate-props-passing-further
branch
from
3195912 to
f41120f
Compare
macobo
approved these changes
Jul 12, 2024
RobertJoonas
pushed a commit
that referenced
this pull request
Jul 12, 2024
…onents (#4340) * Remove query and site props passing from everywhere except class components * Fix invalid import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Followup to #4334, to further alleviate issues from props passing
Tests
Changelog
Documentation
Dark mode