Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main-graph): fix 12mo and other comparisons with blanks #4333

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jul 10, 2024

Some comparisons return blank values. After recent time series fix, this blew up when trying to parse blank as a date.

This fixes the issue and adds a test for a period with blank values

Some comparisons return __blank__ values. After recent time series fix,
this blew up when trying to parse __blank__ as a date.

This fixes the issue and adds a test for a period with __blank__ values
@macobo macobo requested a review from ukutaht July 10, 2024 09:28
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4333

Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@macobo macobo merged commit 645b813 into master Jul 10, 2024
10 checks passed
@macobo macobo deleted the fix-comparison-with-blanks branch July 10, 2024 12:47
RobertJoonas added a commit that referenced this pull request Jul 12, 2024
Some comparisons return __blank__ values. After recent time series fix,
this blew up when trying to parse __blank__ as a date.

This fixes the issue and adds a test for a period with __blank__ values

Co-authored-by: RobertJoonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants