Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors of navigation bar and tab bars #1083

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Conversation

martindsq
Copy link
Member

@martindsq martindsq commented Jan 11, 2023

Closes #1059

  • Update color of the navigation bar
  • Update color of the search bar
  • Update color of the tab bar
  • Remove unused colors
  • Update tab bar icons

IMG_3490B8B48217-1

@martindsq martindsq marked this pull request as ready for review January 17, 2023 20:51
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's SHIP IT 🚢 ! This makes it feel like a whole new app (even though we still have a few more places to update colors)

@mplorentz
Copy link
Member

mplorentz commented Jan 17, 2023

I think we shouldn't close #1059 right after merging this though. Some places I noticed we still need new colors:

  • Settings
  • Notifications tab still uses purple accent
  • Your Network tab still uses purple accent
  • Thread view has wrong background color in light mode.
  • New Post screen

@martindsq
Copy link
Member Author

I think we shouldn't close #1059 right after merging this though. Some places I noticed we still need new colors:

* Settings

* Notifications tab still uses purple accent

* Your Network tab still uses purple accent

* Thread view has wrong background color in light mode.

* New Post screen

The intent behing that issue was what I did, quickly update the navigation bar colors so that they use the new colors we have been using in swiftui. If you are ok with this, I'll close that issue after merging this one, but I'm creating a new issue that a checklist (I'd add the left menu as well that still has the purple)

@martindsq
Copy link
Member Author

I created this other issue for that: #1099

@mplorentz mplorentz merged commit b4cb886 into main Jan 18, 2023
@mplorentz mplorentz deleted the swiftui/navigation_colors branch January 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change colors in uikit to match new color scheme in swift ui
2 participants