Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#7191 Implement new submission wizard #371

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

pkp/pkp-lib#7191 Implement new submission wizard #371

wants to merge 16 commits into from

Conversation

NateWr
Copy link
Contributor

@NateWr NateWr commented Oct 19, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ asmecher
❌ NateWr
You have signed the CLA already but the status is still pending? Let us recheck it.

@NateWr NateWr mentioned this pull request Oct 19, 2022
Closed
@NateWr NateWr force-pushed the i7191_submission_wizard branch 2 times, most recently from d95ad97 to 63368e5 Compare November 8, 2022 11:01
@NateWr NateWr force-pushed the i7191_submission_wizard branch from 63368e5 to f8e6684 Compare November 16, 2022 10:14
@asmecher
Copy link
Member

default.contextSettings.checklist appears to be undefined in OPS.

@NateWr
Copy link
Contributor Author

NateWr commented Nov 21, 2022

default.contextSettings.checklist appears to be undefined in OPS.

Oh yeah. I've fixed that for now, but I'm not sure how appropriate this list is for a preprint server (it's a quick copy from OJS): NateWr@8b2b4a7

There's an issue to improve this for OJS/OMP, which I'll finalize after this is merged. But maybe we need a more appropriate list for OPS? pkp/pkp-lib#8051

@NateWr NateWr force-pushed the i7191_submission_wizard branch from 8b2b4a7 to 50af1f9 Compare November 30, 2022 10:53
NateWr and others added 16 commits December 8, 2022 13:07
@NateWr
pkp/pkp-lib#7191 Implement new submission wizard
b88fa25
@NateWr
pkp/pkp-lib#7191 Changes after code review
680cf08 
- Move email variable code into pkp-lib
- Update submission wizard page handler to reflect changes in pkp-lib
@NateWr
pkp/pkp-lib#7191 Fix submit as user in submission wizard
4c3697f
@NateWr
pkp/pkp-lib#7191 Use camelcase outside of DAO
fef64d1
@NateWr
pkp/pkp-lib#7191 Fix migration filename
9cd3413
@NateWr
pkp/pkp-lib#7191 Remove extra use statements
d8633e2
@asmecher @NateWr
pkp/pkp-lib#7191 Fix duplicate use statements
c3e2deb
@asmecher @NateWr
pkp/pkp-lib#7191 Fix recursive call
a85698e
@asmecher @NateWr
pkp/pkp-lib#7191 Fix ccorino and ckwantes tests for submission wizard
0c5466b
@asmecher @NateWr
pkp/pkp-lib#7191 Add missing use statements
0fb6335
@asmecher @NateWr
pkp/pkp-lib#7191 Convert cmontgomerie test to API
17ad6a9
@asmecher @NateWr
pkp/pkp-lib#7191 Update Cypress tests to use API
e4533e5
@asmecher @NateWr
pkp/pkp-lib#7191 Split submission creation commands into pieces; fix …
2e3c34a 
…author data
@NateWr
pkp/pkp-lib#7191 Fix missing default locale key
6296833
@NateWr
pkp/pkp-lib#7191 Remove unused cypress command
88345b7
@NateWr
Submodule update ##NateWr/i7191_submission_wizard##
1fb5eb5
@NateWr NateWr force-pushed the i7191_submission_wizard branch from d899d4d to 1fb5eb5 Compare December 8, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NateWr @CLAassistant @asmecher