Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erin doc edits #21

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Erin doc edits #21

merged 11 commits into from
Dec 9, 2024

Conversation

ErinWeisbart
Copy link
Collaborator

No description provided.

@ErinWeisbart ErinWeisbart marked this pull request as ready for review December 7, 2024 00:33
@ErinWeisbart
Copy link
Collaborator Author

@bethac07 does this satisfy #10 ?

@ErinWeisbart
Copy link
Collaborator Author

(example-datasets.md still needs a little cleanup.)

@bethac07
Copy link
Contributor

bethac07 commented Dec 7, 2024

Indeed it does solve #10, thanks!

@ErinWeisbart ErinWeisbart linked an issue Dec 9, 2024 that may be closed by this pull request
Describe example datasets (with citations) #10
Closed
@ErinWeisbart ErinWeisbart mentioned this pull request Dec 9, 2024
Closed
@ErinWeisbart
Copy link
Collaborator Author

@bethac07 missing license for C. elegans dataset and citation for Human PLP1 dataset. Can you help with those?

@bethac07
Copy link
Contributor

bethac07 commented Dec 9, 2024

I don't know what the license is for the worms, it's not on BBBC. I don't know that was originally ever collected. Might be worth having Anne reach out.

Citation for PLP1 should nearly certainly be the below, but again, might be worth having Anne confirm, she made that dataset herself.

Lacoste J, Haghighi M, Haider S, Reno C, Lin Z, Segal D, Qian WW, Xiong X, Teelucksingh T, Miglietta E, Shafqat-Abbasi H, Ryder PV, Senft R, Cimini BA, Murray RR, Nyirakanani C, Hao T, McClain GG, Roth FP, Calderwood MA, Hill DE, Vidal M, Yi SS, Sahni N, Peng J, Gingras A, Singh S, Carpenter AE, Taipale M. Pervasive mislocalization of pathogenic coding variants underlying human disorders. Cell. 2024. doi: 10.1016/j.cell.2024.09.003

@AnneCarpenter
Copy link

Confirmed PLP2! Asked Javier just now by email

@AnneCarpenter
Copy link

Javier confirms: "please place those images under CC0."
Thanks!

@ErinWeisbart
Copy link
Collaborator Author

@bethac07 This is ready for review.

@bethac07 bethac07 merged commit 7bdb444 into main Dec 9, 2024
1 check passed
@bethac07 bethac07 deleted the erin_doc_edits branch December 9, 2024 19:45
@bethac07 bethac07 linked an issue Dec 9, 2024 that may be closed by this pull request
Links don't work on technical FAQ page #27
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethac07 bethac07 bethac07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links don't work on technical FAQ page Describe example datasets (with citations)
3 participants
@ErinWeisbart @bethac07 @AnneCarpenter