Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature: trigger にエイリアスを追加する #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

New feature: trigger にエイリアスを追加する #64

wants to merge 2 commits into from

Conversation

zztkm
Copy link
Member

@zztkm zztkm commented Jul 7, 2022 •
edited
Loading

#63 の対応

@quojama quojama temporarily deployed to takohachi-pi-feature-63-mnvwkm July 7, 2022 18:09 Inactive
@quojama quojama temporarily deployed to takohachi-pi-feature-63-mnvwkm July 8, 2022 00:57 Inactive
@zztkm zztkm requested a review from quojama July 8, 2022 00:57
@zztkm zztkm self-assigned this Jul 8, 2022
@zztkm zztkm added the enhancement New feature or request label Jul 8, 2022
@zztkm zztkm marked this pull request as ready for review July 8, 2022 00:58
@quojama quojama temporarily deployed to takohachi-pi-feature-63-sbanqp July 8, 2022 10:06 Inactive
quojama
quojama reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@quojama quojama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なんかわからんが動いてないということはわかった。コメントのとこ直したらいけたりするのかな。多分無理っぽいが

cogs/trigger.py
Returns:
Optional[int]: trigger が含まれている行番号
"""
trigger_columns = ["trigger", "alias01", "alias01"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ

["trigger", "alias01", "alias02"]

かな？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはおれもさっき思いました

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

["trigger", "alias01", "alias02"]
に直した上でローカルで試してみたらalias01カラムは反応したが、alias02カラムは反応しなかった。

報告いたします。

@zztkm zztkm changed the base branch from master to main January 7, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quojama quojama quojama left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@zztkm zztkm

Labels
enhancement New feature or request
Projects
🌋Pistachio Studio & Gaming is not dead
Status: ⚔Todo (maybe)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zztkm @quojama