feat(create3): allow deployed solely based on salt #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal,
0xHansLee and
leeren
as code owners
Ramarti
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Please change this Natspec
/**
* @title Create3
* @notice Factory for deploying contracts to deterministic addresses via CREATE3 Enables deploying
* contracts using CREATE3. Each deployer (msg.sender) has its own namespace for deployed
* addresses.
* @author zefram.eth
* @custom:attribution zefram.eth (https://github.com/ZeframLou/create3-factory/blob/main/src/CREATE3Factory.sol)
*/
To one that says it's based on zefram's code but we also added methods.
Otherwise LGTM
kingster-will
changed the title
edisonz0718
approved these changes
Dec 14, 2024
Binary uploaded successfully 🎉📦 Version Name: 0.14.1-unstable-17eaf99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance pre-deployed CREATE3 to support deploying contracts to deterministic addresses calculated solely based on the salt, independent of the deployer address.
issue: none