Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurability #1

Merged
merged 7 commits into from
Mar 9, 2018
Merged

Configurability #1

merged 7 commits into from
Mar 9, 2018

Conversation

kedean
Copy link
Contributor

@kedean kedean commented May 23, 2016

Added configuration options using the built-in argparse library. New options are:

  • symbol_set to set one or more symbol sets to use randomly from the archive (e.g. --symbol_set THICK THIN), defaults to ASCII
  • max_framerate to control the sleep time between redraws, defaults to 100
  • color_set to allow choosing which colors to draw with. User can use 'random' to use the old behavior
  • min_pipes to set the fewest starting points for the algorithm, defaults to 5
  • max_pipes to set the most starting points for the algorithm, defaults to 25

Also modified the exit routine so that it does not trash the terminal on exit.

@Foggalong Foggalong added the merge label Sep 2, 2016
@neeasade
Copy link

perf

@livibetter
Copy link
Contributor

livibetter commented Feb 15, 2018

@KonradIT could you review this? (and watch the repo)

@kedean because nature of this issue and even over 100 lines changes, I will be willing to merge this if it gets approval votes.

2018-02-15T10:42:19Z edited: s/couldn't/could/

@livibetter livibetter requested a review from KonradIT February 15, 2018 10:43
@livibetter livibetter self-assigned this Mar 9, 2018
@livibetter livibetter removed the request for review from KonradIT March 9, 2018 08:54
@livibetter
Copy link
Contributor

Merging this, even though I'd like to make some changes request, but because this was created nearly two years ago, so I won't be asking and will be doing the changes by myself.


@kedean @neeasade I have checked out your GitHub profiles (C, Python, Bash/Shell, and/or AUR packaging), I wonder if you will be interested in joining Pipeseroni. we are looking for new devs.

As you may already know we have several pipes in different languages, currently we are focusing on pipes.sh, pipes.c, and the AUR packaging (yet to get started). If you have the time and are interested in, please do consider.

@livibetter livibetter merged commit b1c225f into pipeseroni:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants