Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialout to the Daily phone example #998

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

chadbailey59
Copy link
Contributor

This PR renames the dialin-chatbot example to phone-chatbot, and adds dial-out support to the Daily example. We'd welcome another PR to add dial-out support for the Twilio example too. :)

@chadbailey59
Copy link
Contributor Author

One thing of note: the on_dialout_answered hook doesn't seem to be firing.

@markbackman
Copy link
Contributor

@chadbailey59 I pushed two commits:

  1. I just found a typo in a variable (not yours)
  2. I added more more explicit instructions in the README to keep developers on the rails when they test this. Please confirm that the steps and info are accurate. The Twilio example is unclear to me. I added the setup boilerplate to it, but we need clearer instructions about how to dial-in. As is, I would be left to guess on how to dial-in to a Twilio room. Ideally, the instructions are thorough enough that there is no ambiguity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants