chore(ai_services): raise exception if api_key None or empty #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Jan 22, 2025
aconchillo
reviewed
Jan 22, 2025
src/pipecat/services/moondream.py
Outdated
| @@ -44,6 +44,7 @@ def __init__( | |||
| self, *, model="vikhyatk/moondream2", revision="2024-08-26", use_cpu=False, **kwargs | |||
| ): | |||
| super().__init__(**kwargs) | |||
| self._require_api_key = False | |||
There was a problem hiding this comment.
super().__init__(require_api_key = False, **kwargs)
aconchillo
reviewed
Jan 22, 2025
aconchillo
reviewed
Jan 22, 2025
aconchillo
reviewed
Jan 22, 2025
Vaibhav159
suggested changes
Jan 22, 2025
src/pipecat/services/ai_services.py
Outdated
| @@ -61,7 +63,10 @@ def set_model_name(self, model: str): | |||
| self.set_core_metrics_data(MetricsData(processor=self.name, model=self._model_name)) | |||
|
|
|||
| async def start(self, frame: StartFrame): | |||
| pass | |||
| if self._require_api_key and not self._api_key: | |||
| raise Exception(f"{self}: Error: No api_key value found.") | |||
There was a problem hiding this comment.
can we create a custom expection for this, like APIKeyMissing / APIKeyError, this is save us from cases where we would need to catch it but can only do it via expect Exception
vipyne
force-pushed
the
vp-941-raise-no-api-key-exception
branch
2 times, most recently
from
8d629d6 to
1674c85
Compare
vipyne
force-pushed
the
vp-941-raise-no-api-key-exception
branch
from
1674c85 to
4a7d5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
closes #941
Raises exception if the value of an API key is None or empty.