Update dynamic flows to use a per-function transition handler, support node functions #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jan 21, 2025
muranski
reviewed
Jan 21, 2025
|
|
||
| # After - per-function transitions | ||
| flow_manager = FlowManager( | ||
| transition_callbacks={ |
There was a problem hiding this comment.
As an alternative, I would consider specifying the per-function transition handler directly in the function definition code, similar to how static flow management specifies the "transition_to" field.
For example:
def create_marital_status_node() -> NodeConfig:
"""Create node for collecting marital status."""
return {
"task_messages": [
{
"role": "system",
"content": "Ask about the customer's marital status for premium calculation.",
}
],
"functions": [
{
"type": "function",
"function": {
"name": "collect_marital_status",
"handler": collect_marital_status,
"description": "Record marital status",
"parameters": {
"type": "object",
"properties": {
"marital_status": {"type": "string", "enum": ["single", "married"]}
},
"required": ["marital_status"],
},
},
"transition_callback": handle_marital_status_collection,
}
],
}
I prefer this approach because it is more consistent with the static flow management style.
There was a problem hiding this comment.
I'm considering this. I'm going to merge this change, then I'll open a new PR to see how making the change you suggested looks.
filipi87
reviewed
Jan 21, 2025
| @@ -253,7 +254,7 @@ async def get_movies() -> Union[MoviesResult, ErrorResult]: | |||
| return MoviesResult(movies=movies) | |||
| except Exception as e: | |||
| logger.error(f"TMDB API Error: {e}") | |||
| return ErrorResult(error="Failed to fetch movies") | |||
| return ErrorResult(status="error", error="Failed to fetch movies") | |||
There was a problem hiding this comment.
Do we need to apply these same changes in the example below, movie_explorer_gemini.py
? Include the status="error" ?
filipi87
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to this issue: #77.
Taking a chance to improve the architecture and dev ex, though that introduces a breaking change.