Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init grpc server of wait stage plugin #5445

Merged
merged 7 commits into from
Dec 25, 2024
Merged

Init grpc server of wait stage plugin #5445

merged 7 commits into from
Dec 25, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 24, 2024

What this PR does:

Add initial code for launching a grpc server of the wait stage plugin.
It does not contain the core logic of waiting yet.

  • pkg/app/pipedv1/plugin/wait/main.go: entrypoint
    • almost the same as pkg/app/pipedv1/plugin/kubernetes/main.go
  • pkg/app/pipedv1/plugin/wait/server.go: init a grpc server
    • almost the same as pkg/app/pipedv1/plugin/kubernetes/server.go
  • pkg/app/pipedv1/plugin/wait/execute/server.go: implement server interface
    • similar to pkg/app/pipedv1/plugin/kubernetes/deployment/server.go
  • pkg/app/pipedv1/plugin/wait/execute/wait.go: the core logic of wait stage

Why we need it:

  • To run the wait stage as a grpc server plugin

Which issue(s) this PR fixes:

Part of #5367

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 150 lines in your changes missing coverage. Please review.

Project coverage is 26.14%. Comparing base (fdc490c) to head (ce4ebfb).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/wait/server.go 0.00% 99 Missing ⚠️
pkg/app/pipedv1/plugin/wait/execute/server.go 0.00% 37 Missing ⚠️
pkg/app/pipedv1/plugin/wait/main.go 0.00% 11 Missing ⚠️
pkg/app/pipedv1/plugin/wait/execute/wait.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5445      +/-   ##
==========================================
- Coverage   26.21%   26.14%   -0.07%     
==========================================
  Files         452      456       +4     
  Lines       48890    49040     +150     
==========================================
+ Hits        12817    12823       +6     
- Misses      35048    35192     +144     
  Partials     1025     1025              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: t-kikuc <[email protected]>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit ef4f6d3 into master Dec 25, 2024
16 of 18 checks passed
@t-kikuc t-kikuc deleted the plugin/wait_main branch December 25, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants