-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init grpc server of wait stage plugin #5445
Conversation
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5445 +/- ##
==========================================
- Coverage 26.21% 26.14% -0.07%
==========================================
Files 452 456 +4
Lines 48890 49040 +150
==========================================
+ Hits 12817 12823 +6
- Misses 35048 35192 +144
Partials 1025 1025 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What this PR does:
Add initial code for launching a grpc server of the wait stage plugin.
It does not contain the core logic of waiting yet.
pkg/app/pipedv1/plugin/wait/main.go
: entrypointpkg/app/pipedv1/plugin/kubernetes/main.go
pkg/app/pipedv1/plugin/wait/server.go
: init a grpc serverpkg/app/pipedv1/plugin/kubernetes/server.go
pkg/app/pipedv1/plugin/wait/execute/server.go
: implement server interfacepkg/app/pipedv1/plugin/kubernetes/deployment/server.go
pkg/app/pipedv1/plugin/wait/execute/wait.go
: the core logic of wait stageWhy we need it:
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: