Implement pipectl migrate with get then set at pipectl side (#5506)

* Add an RPC UpdateApplicationDeployTargets Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Implement UpdateApplicationDeployTargets Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Implement pipectl migrate database with new RPCs Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Remove unused RPC Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
pipe-cd · Jan 23, 2025 · cc28c03 · cc28c03
1 parent 0437a92
commit cc28c03
Show file tree

Hide file tree

Showing 6 changed files with 955 additions and 1,150 deletions.
diff --git a/pkg/app/pipectl/cmd/migrate/database.go b/pkg/app/pipectl/cmd/migrate/database.go
@@ -55,7 +55,7 @@ func (c *database) run(ctx context.Context, input cli.Input) error {
 
 	for _, appID := range c.applications {
 		input.Logger.Info("migrating database", zap.String("application", appID))
-		if err := c.migrateApplication(ctx, client, appID); err != nil {
+		if err := c.migrateApplication(ctx, client, appID, input.Logger); err != nil {
 			input.Logger.Error("failed to migrate database", zap.String("application", appID), zap.Error(err))
 			return err
 		}
@@ -65,16 +65,33 @@ func (c *database) run(ctx context.Context, input cli.Input) error {
 	return nil
 }
 
-func (c *database) migrateApplication(ctx context.Context, client apiservice.Client, appID string) error {
-	req := &apiservice.MigrateDatabaseRequest{
-		Target: &apiservice.MigrateDatabaseRequest_Application_{
-			Application: &apiservice.MigrateDatabaseRequest_Application{
-				ApplicationId: appID,
-			},
-		},
+func (c *database) migrateApplication(ctx context.Context, client apiservice.Client, appID string, logger *zap.Logger) error {
+	app, err := client.GetApplication(ctx, &apiservice.GetApplicationRequest{ApplicationId: appID})
+	if err != nil {
+		logger.Error("failed to get application", zap.Error(err), zap.String("application", appID))
+		return err
 	}
-	if _, err := client.MigrateDatabase(ctx, req); err != nil {
+
+	if len(app.GetApplication().GetDeployTargets()) > 0 {
+		logger.Info("skip migrating database because the deploy target is already set", zap.String("application", appID))
+		return nil
+	}
+
+	provider := app.GetApplication().GetPlatformProvider()
+
+	if provider == "" {
+		logger.Info("skip migrating database because the platform provider is not set", zap.String("application", appID))
+		return nil
+	}
+
+	// Migrate database for the application.
+	if _, err := client.UpdateApplicationDeployTargets(ctx, &apiservice.UpdateApplicationDeployTargetsRequest{
+		ApplicationId: appID,
+		DeployTargets: []string{provider},
+	}); err != nil {
+		logger.Error("failed to update application deploy targets", zap.Error(err), zap.String("application", appID))
 		return err
 	}
+
 	return nil
 }
diff --git a/pkg/app/server/grpcapi/api.go b/pkg/app/server/grpcapi/api.go
@@ -463,6 +463,27 @@ func (a *API) RenameApplicationConfigFile(ctx context.Context, req *apiservice.R
 	return &apiservice.RenameApplicationConfigFileResponse{}, nil
 }
 
+func (a *API) UpdateApplicationDeployTargets(ctx context.Context, req *apiservice.UpdateApplicationDeployTargetsRequest) (*apiservice.UpdateApplicationDeployTargetsResponse, error) {
+	key, err := requireAPIKey(ctx, model.APIKey_READ_WRITE, a.logger)
+	if err != nil {
+		return nil, err
+	}
+
+	app, err := getApplication(ctx, a.applicationStore, req.ApplicationId, a.logger)
+	if err != nil {
+		a.logger.Warn("failed to get application", zap.Error(err))
+		return nil, err
+	}
+	if app.ProjectId != key.ProjectId {
+		a.logger.Warn("requested application does not belong to your project", zap.String("applicationID", app.Id), zap.String("requestProjectID", key.ProjectId), zap.String("applicationProjectID", app.ProjectId))
+		return nil, status.Error(codes.PermissionDenied, fmt.Sprintf("requested application %s does not belong to your project", req.GetApplicationId()))
+	}
+	if err := a.applicationStore.UpdateDeployTargets(ctx, req.GetApplicationId(), req.GetDeployTargets()); err != nil {
+		return nil, gRPCStoreError(err, fmt.Sprintf("failed to update application %s deploy targets", req.ApplicationId))
+	}
+	return &apiservice.UpdateApplicationDeployTargetsResponse{}, nil
+}
+
 func (a *API) GetDeployment(ctx context.Context, req *apiservice.GetDeploymentRequest) (*apiservice.GetDeploymentResponse, error) {
 	key, err := requireAPIKey(ctx, model.APIKey_READ_ONLY, a.logger)
 	if err != nil {
@@ -1023,33 +1044,6 @@ func (a *API) Encrypt(ctx context.Context, req *apiservice.EncryptRequest) (*api
 	}, nil
 }
 
-func (a *API) MigrateDatabase(ctx context.Context, req *apiservice.MigrateDatabaseRequest) (*apiservice.MigrateDatabaseResponse, error) {
-	if _, err := requireAPIKey(ctx, model.APIKey_READ_WRITE, a.logger); err != nil {
-		return nil, err
-	}
-
-	switch { //nolint:gocritic // we plan to add more cases
-	case req.GetApplication() != nil:
-		if err := a.migrateApplication(ctx, req.GetApplication()); err != nil {
-			a.logger.Error("failed to migrate application", zap.Error(err))
-			return nil, err
-		}
-		return &apiservice.MigrateDatabaseResponse{}, nil
-	}
-	return nil, status.Error(codes.Unimplemented, "Not implemented")
-}
-
-func (a *API) migrateApplication(ctx context.Context, app *apiservice.MigrateDatabaseRequest_Application) error {
-	application, err := getApplication(ctx, a.applicationStore, app.ApplicationId, a.logger)
-	if err != nil {
-		return gRPCStoreError(err, "get application")
-	}
-	if err := a.applicationStore.UpdateDeployTargets(ctx, app.ApplicationId, []string{application.PlatformProvider}); err != nil {
-		return gRPCStoreError(err, "update application")
-	}
-	return nil
-}
-
 // requireAPIKey checks the existence of an API key inside the given context
 // and ensures that it has enough permissions for the give role.
 func requireAPIKey(ctx context.Context, role model.APIKey_Role, logger *zap.Logger) (*model.APIKey, error) {