Skip to content

Commit

Permalink
Implement adding config hash annotation to deployments (#5418)
Browse files Browse the repository at this point in the history
* Add annotation key constant

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add IsDeployment method to ResourceKey

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add AddStringMapValues method to Manifest

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Implement config hash annotation to Kubernetes deployment manifests

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add unit tests for ResourceKey.IsDeployment method

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add unit tests for AddStringMapValues method in Manifest

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
  • Loading branch information
Warashi authored Dec 13, 2024
1 parent fd58db0 commit 702b984
Show file tree
Hide file tree
Showing 7 changed files with 671 additions and 1 deletion.
110 changes: 110 additions & 0 deletions pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
// Copyright 2024 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package deployment

import (
"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/kubernetes/provider"
)

// annotateConfigHash appends a hash annotation into the workload manifests.
// The hash value is calculated by hashing the content of all configmaps/secrets
// that are referenced by the workload.
// This appending ensures that the workload should be restarted when
// one of its configurations changed.
func annotateConfigHash(manifests []provider.Manifest) error {
if len(manifests) == 0 {
return nil
}

configMaps := make(map[string]provider.Manifest)
secrets := make(map[string]provider.Manifest)
for _, m := range manifests {
if m.Key.IsConfigMap() {
configMaps[m.Key.Name] = m
continue
}
if m.Key.IsSecret() {
secrets[m.Key.Name] = m
}
}

// This application is not containing any config manifests
// so nothing to do.
if len(configMaps)+len(secrets) == 0 {
return nil
}

for _, m := range manifests {
if m.Key.IsDeployment() {
if err := annotateConfigHashToWorkload(m, configMaps, secrets); err != nil {
return err
}

// TODO: Add support for other workload types, such as StatefulSet, DaemonSet, etc.
}
}

return nil
}

func annotateConfigHashToWorkload(m provider.Manifest, managedConfigMaps, managedSecrets map[string]provider.Manifest) error {
configMaps := provider.FindReferencingConfigMaps(m.Body)
secrets := provider.FindReferencingSecrets(m.Body)

// The deployment is not referencing any config resources.
if len(configMaps)+len(secrets) == 0 {
return nil
}

cfgs := make([]provider.Manifest, 0, len(configMaps)+len(secrets))
for _, cm := range configMaps {
m, ok := managedConfigMaps[cm]
if !ok {
// We do not return error here because the deployment may use
// a config resource that is not managed by PipeCD.
continue
}
cfgs = append(cfgs, m)
}
for _, s := range secrets {
m, ok := managedSecrets[s]
if !ok {
// We do not return error here because the deployment may use
// a config resource that is not managed by PipeCD.
continue
}
cfgs = append(cfgs, m)
}

if len(cfgs) == 0 {
return nil
}

hash, err := provider.HashManifests(cfgs)
if err != nil {
return err
}

m.AddStringMapValues(
map[string]string{
provider.AnnotationConfigHash: hash,
},
"spec",
"template",
"metadata",
"annotations",
)
return nil
}
Loading

0 comments on commit 702b984

Please sign in to comment.