Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2972 to v3 #2973

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Backport #2972 to v3 #2973

merged 1 commit into from
Dec 15, 2024

Conversation

jech
Copy link
Member

@jech jech commented Dec 15, 2024

Backport of #2972 into v3.

Tested to do the right thing in Galene, thanks a lot Sean.

Update MediaEngine codec creation to take into account remote
and local rtcp-fb. Before we would incorrectly always take
the remote rtcp-fb and ignore local.

Resolves pion#2943
Resolves pion#2944
Resolves pion#1968
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.90%. Comparing base (90222f6) to head (ed84fad).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
mediaengine.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2973      +/-   ##
==========================================
- Coverage   80.16%   78.90%   -1.27%     
==========================================
  Files          78       78              
  Lines        7659     9318    +1659     
==========================================
+ Hits         6140     7352    +1212     
- Misses       1079     1528     +449     
+ Partials      440      438       -2     
Flag Coverage Δ
go 78.90% <95.23%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jech jech merged commit ed84fad into pion:v3 Dec 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants