Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pessimistic String calls for low level logs #389

Closed
wants to merge 1 commit into from

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented Apr 19, 2024

there is no need to manually stringify types that implement fmt.Stringer. if the log line is printed the formatter for %s will do this.

@paulwe paulwe requested review from davidzhao and boks1971 April 19, 2024 23:43
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (cf40c33) to head (5528f7b).

❗ Current head 5528f7b differs from pull request most recent head 71ef030. Consider uploading reports for the commit 71ef030 to get more accurate results

Files Patch % Lines
client.go 40.00% 3 Missing ⚠️
internal/allocation/allocation.go 80.00% 1 Missing ⚠️
internal/server/turn.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   68.24%   68.40%   +0.15%     
==========================================
  Files          43       43              
  Lines        2337     2333       -4     
==========================================
+ Hits         1595     1596       +1     
+ Misses        576      573       -3     
+ Partials      166      164       -2     
Flag Coverage Δ
go 68.40% <79.16%> (+0.15%) ⬆️
wasm 27.64% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe changed the title Remove pessimistic stringer calls for low level logs Remove pessimistic string calls for low level logs Apr 19, 2024
@paulwe paulwe changed the title Remove pessimistic string calls for low level logs Remove pessimistic String calls for low level logs Apr 19, 2024
@paulwe paulwe closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants