Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of WASM-page using Go instead of TinyGo #44

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

stv0g
Copy link
Member

@stv0g stv0g commented May 5, 2023

I've simplified the code quite considerable, by using standard Go for building the WASM code.

@stv0g stv0g force-pushed the fix-wasm-build branch from 7d4457d to 54d8755 Compare May 5, 2023 16:14
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 68.66%. Comparing base (3697adc) to head (2bafa8b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/wasm/main.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   67.02%   68.66%   +1.63%     
==========================================
  Files          10       10              
  Lines         461      450      -11     
==========================================
  Hits          309      309              
+ Misses        144      133      -11     
  Partials        8        8              
Flag Coverage Δ
go 71.69% <ø> (+4.66%) ⬆️
wasm 38.22% <0.00%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stv0g stv0g force-pushed the fix-wasm-build branch from 54d8755 to 520b03d Compare May 5, 2023 16:15
@stv0g stv0g requested a review from Sean-Der May 5, 2023 16:28
@Sean-Der Sean-Der merged commit 07a577f into master Jan 24, 2025
11 of 13 checks passed
@Sean-Der Sean-Der deleted the fix-wasm-build branch January 24, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants