Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: fix timedout typo #2345

Closed
wants to merge 2 commits into from
Closed

typo: fix timedout typo #2345

wants to merge 2 commits into from

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Dec 28, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar December 28, 2023 09:09
Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (48b5119) 53.38% compared to head (5f5bb91) 53.37%.

❗ Current head 5f5bb91 differs from pull request most recent head eb87a40. Consider uploading reports for the commit eb87a40 to get more accurate results

Files Patch % Lines
pkg/cluster/executor/ssh.go 0.00% 2 Missing ⚠️
pkg/exec/run.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   53.38%   53.37%   -0.01%     
==========================================
  Files         328      328              
  Lines       34828    34828              
==========================================
- Hits        18591    18587       -4     
- Misses      13978    13981       +3     
- Partials     2259     2260       +1     
Flag Coverage Δ
tiup 33.56% <0.00%> (-0.05%) ⬇️
unittest 22.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2023
@breezewish
Copy link
Member

Timedout is typo of timed out instead of timeout:

  • Timeout: n.
    Example: The timeout of an operation is 10 minutes.
  • Timed out: v. (past)
    Example: Timed out waiting for the operation to finish.

@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 29, 2023

Timedout is typo of timed out instead of timeout:

  • Timeout: n.
    Example: The timeout of an operation is 10 minutes.
  • Timed out: v. (past)
    Example: Timed out waiting for the operation to finish.

get it

@HuSharp HuSharp closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants