Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: make schdule support compact #6033

Merged
merged 46 commits into from
Jan 23, 2025
Merged

br: make schdule support compact #6033

merged 46 commits into from
Jan 23, 2025

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Jan 13, 2025

What problem does this PR solve?

Ref: pingcap/tidb#56522

What is changed and how does it work?

Modify the schdule cr to support compact

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge January 13, 2025 03:31
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 13, 2025
@RidRisR RidRisR changed the title Schdule br: make schdule support compact Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 21.42857% with 297 lines in your changes missing coverage. Please review.

Project coverage is 62.47%. Comparing base (a16b2e8) to head (a5705ef).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
+ Coverage   57.19%   62.47%   +5.27%     
==========================================
  Files         259      269      +10     
  Lines       33233    46817   +13584     
==========================================
+ Hits        19008    29247   +10239     
- Misses      12291    15532    +3241     
- Partials     1934     2038     +104     
Flag Coverage Δ
e2e 46.50% <0.32%> (?)
unittest 55.72% <21.16%> (-1.48%) ⬇️

pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
pkg/backup/backupschedule/backup_schedule_manager.go Outdated Show resolved Hide resolved
@RidRisR RidRisR requested a review from WangLe1321 January 22, 2025 06:04
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 23, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 06:05:24.726424211 +0000 UTC m=+333652.057343610: ☑️ agreed by WangLe1321.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2025
@RidRisR
Copy link
Contributor Author

RidRisR commented Jan 23, 2025

/run-all-tests

Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WangLe1321,csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-serial

@RidRisR
Copy link
Contributor Author

RidRisR commented Jan 23, 2025

/run-pull-e2e-kind-basic

@ti-chi-bot ti-chi-bot bot merged commit f8ebb9c into pingcap:master Jan 23, 2025
13 checks passed
@RidRisR RidRisR deleted the schdule branch January 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants