Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that pod spec's hash may be changed when new fields are added to the PodSpec #6030

Open
wants to merge 1 commit into
base: feature/v2
Choose a base branch
from

Conversation

fgksgf
Copy link
Contributor

@fgksgf fgksgf commented Jan 10, 2025

…d spec

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.99%. Comparing base (33926aa) to head (cca6d12).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6030      +/-   ##
==============================================
- Coverage       58.00%   57.99%   -0.02%     
==============================================
  Files             153      153              
  Lines            9432     9434       +2     
==============================================
  Hits             5471     5471              
- Misses           3961     3963       +2     
Flag Coverage Δ
unittest 57.99% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@fgksgf
Copy link
Contributor Author

fgksgf commented Jan 10, 2025

/run-pull-e2e-kind-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants