Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance): fix pvc names of all instances #6028

Open
wants to merge 2 commits into
base: feature/v2
Choose a base branch
from
Open

fix(instance): fix pvc names of all instances #6028

wants to merge 2 commits into from

Conversation

liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Jan 10, 2025 •
edited
Loading

  • fix pvc name generation
  • add uts

Wait for #6026

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (33926aa) to head (443694e).

Additional details and impacted files 
@@               Coverage Diff               @@
##           feature/v2    #6028       +/-   ##
===============================================
+ Coverage       58.00%   70.04%   +12.03%     
===============================================
  Files             153      153               
  Lines            9432     9437        +5     
===============================================
+ Hits             5471     6610     +1139     
+ Misses           3961     2827     -1134
Flag Coverage Δ
unittest 70.04% <73.33%> (+12.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from liubog2008, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008 liubog2008 force-pushed the liubo02/add-ut-v3 branch 2 times, most recently from 06eb2e4 to 73c3527 Compare January 10, 2025 06:38
@liubog2008 liubog2008 added the v2 for operator v2 label Jan 10, 2025
@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-v2

1 similar comment
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008
fix lint
443694e 
Signed-off-by: liubo02 <[email protected]>
@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL v2 for operator v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liubog2008 @codecov-commenter @csuzhangxc