Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): move to task v3 #6022

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

liubog2008
Copy link
Member

  • move all instance controllers to task v3

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 7, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 820 lines in your changes missing coverage. Please review.

Project coverage is 50.57%. Comparing base (35d5ac7) to head (240e115).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6022      +/-   ##
==============================================
+ Coverage       48.35%   50.57%   +2.21%     
==============================================
  Files             154      154              
  Lines           10009     9459     -550     
==============================================
- Hits             4840     4784      -56     
+ Misses           5169     4675     -494     
Flag Coverage Δ
unittest 50.57% <0.00%> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@liubog2008 liubog2008 added the v2 for operator v2 label Jan 7, 2025
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 1dbb5b1 into pingcap:feature/v2 Jan 7, 2025
7 of 8 checks passed
@liubog2008 liubog2008 deleted the liubo02/move-to-v3 branch January 7, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants