-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(group): move tiflashgroup to v3 and extract some common tasks #6021
feat(group): move tiflashgroup to v3 and extract some common tasks #6021
Conversation
liubog2008
commented
Jan 3, 2025
•
edited
Loading
edited
- Move tiflashgroup to task v3
- Extract common revision task
- Extract common status task
- Fix labels of controller revision
- Previously use all labels of the group but selected by some specified labels which may not be set by users.
- Remove truncate history task(will add back soon)
Signed-off-by: liubo02 <[email protected]>
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6021 +/- ##
==============================================
+ Coverage 47.90% 48.35% +0.45%
==============================================
Files 154 154
Lines 10089 10009 -80
==============================================
+ Hits 4833 4840 +7
+ Misses 5256 5169 -87
Flags with carried forward coverage won't be shown. Click here to find out more. |
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
/run-pull-e2e-kind-v2 |
2 similar comments
/run-pull-e2e-kind-v2 |
/run-pull-e2e-kind-v2 |
@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |