Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group): move tiflashgroup to v3 and extract some common tasks #6021

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Jan 3, 2025

  • Move tiflashgroup to task v3
  • Extract common revision task
  • Extract common status task
  • Fix labels of controller revision
    • Previously use all labels of the group but selected by some specified labels which may not be set by users.
  • Remove truncate history task(will add back soon)

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 3, 2025
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 65.10949% with 239 lines in your changes missing coverage. Please review.

Project coverage is 48.35%. Comparing base (8468aa9) to head (4e59401).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6021      +/-   ##
==============================================
+ Coverage       47.90%   48.35%   +0.45%     
==============================================
  Files             154      154              
  Lines           10089    10009      -80     
==============================================
+ Hits             4833     4840       +7     
+ Misses           5256     5169      -87     
Flag Coverage Δ
unittest 48.35% <65.10%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <[email protected]>
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <[email protected]>
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

2 similar comments
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008 liubog2008 added the v2 for operator v2 label Jan 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 35d5ac7 into pingcap:feature/v2 Jan 7, 2025
7 of 8 checks passed
@liubog2008 liubog2008 deleted the liubo02/refactor-tiflash branch January 7, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants