Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove tikv-importer #5391

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 November 14, 2023 07:04
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge November 14, 2023 07:04
@ti-chi-bot ti-chi-bot bot added the size/XXL label Nov 14, 2023
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Merging #5391 (db6ae68) into master (a076c0e) will increase coverage by 3.42%.
Report is 1 commits behind head on master.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5391      +/-   ##
==========================================
+ Coverage   61.60%   65.03%   +3.42%     
==========================================
  Files         228      239      +11     
  Lines       28864    32613    +3749     
==========================================
+ Hits        17782    21209    +3427     
- Misses       9340     9637     +297     
- Partials     1742     1767      +25     
Flag Coverage Δ
e2e 41.41% <ø> (?)
unittest 61.58% <33.33%> (-0.03%) ⬇️

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc csuzhangxc merged commit 996c48f into pingcap:master Nov 16, 2023
4 checks passed
@csuzhangxc csuzhangxc deleted the remove-importer branch November 16, 2023 03:30
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5394.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
10 tasks
csuzhangxc added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants