Replace GitHub URLs outside of the owner namespace to avoid backlink spam #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spruce
reviewed
Jan 29, 2025
src/githubHelper.ts
Outdated
| return str.replace('github.com', 'redirect.github.com'); | ||
| } | ||
|
|
||
| reString = `https:\\/\\/github\\.com\\/(?!${settings.github.owner}).+\\/.+\\/\\d+`; |
There was a problem hiding this comment.
Are you sure the regex is correct?
Multiple things:
- Doesn't the regex match only digits in the last path part of the URL? (What do you think about just ignoring the part after the org/owner completely?)
- Are the double backslashes really required? I did think not.
- Doesn't need the lookahead need a slash at the end as well so we are sure it is not my robofriends repo (github.com/spruce1/...) for example
There was a problem hiding this comment.
Good points. I looked at how renovate does it and they replace all URLs as long as it doesn't start with certain subdomains that already redirect:
So yes, we could do that while maintaining internal links intact.
The double backslashes are required (all the existing regexes have this as well).
There was a problem hiding this comment.
Fixed, please have a look again
mschoettle
force-pushed
the
rewrite-github-urls
branch
from
ab2707a to
ec1f92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
github.comin URLs withredirect.github.comto avoid backlink spam.This is only done when the URL points to outside of the owner of the GitHub namespace, e.g., the organization, to keep internal backlinks.
Fixes #211