Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args overwrite bug in exlude_tags #331

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

klemens-st
Copy link
Collaborator

Right now instead of $args, $params are passed to lcp_excluded_tags. This small bug means that if a user specifies exclude_tags shortcode parameter, two things happen:

  1. Any $args set and parsed above line 142 of lcp-parameters.php will be ignored, e.g. excludeposts, before_year etc.
  2. A full array of raw LCP parameters will be passed to WP_Query

This is fixed in this PR.

Fixes https://wordpress.org/support/topic/excludepoststhis-not-working/

@picandocodigo picandocodigo merged commit ad5d1c2 into picandocodigo:master Aug 13, 2018
@picandocodigo
Copy link
Owner

Thanks as always @zymeth25! I haven't had much time recently, but as soon as I do, I'll try to get the rest of the PR's in.

@klemens-st klemens-st deleted the fix-exclude-tags branch August 13, 2018 13:18
@klemens-st
Copy link
Collaborator Author

@picandocodigo Great! No rush about the rest, I'll keep sending small fixes when necessary but to continue refactoring and making things easier we need to deal with #288 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants