Fix args overwrite bug in exlude_tags #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now instead of
$args
,$params
are passed tolcp_excluded_tags
. This small bug means that if a user specifiesexclude_tags
shortcode parameter, two things happen:$args
set and parsed above line 142 of lcp-parameters.php will be ignored, e.g.excludeposts
,before_year
etc.WP_Query
This is fixed in this PR.
Fixes https://wordpress.org/support/topic/excludepoststhis-not-working/