Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from NVIDIA:main #41

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[pull] main from NVIDIA:main #41

merged 3 commits into from
Dec 17, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 17, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

youngeunkwon0405 and others added 3 commits December 16, 2024 15:39
…1358)

* draft implementation of fsdp2 fp8 all gather

Signed-off-by: Youngeun Kwon <[email protected]>

* fix the convergence issue

Signed-off-by: Youngeun Kwon <[email protected]>

* Add warning

Signed-off-by: Youngeun Kwon <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* disable lint error

Signed-off-by: Youngeun Kwon <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix the lint error

Signed-off-by: Youngeun Kwon <[email protected]>

* fix lint error

Signed-off-by: Youngeun Kwon <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix lint error

Signed-off-by: Youngeun Kwon <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix lint error

Signed-off-by: Youngeun Kwon <[email protected]>

* add comments

Signed-off-by: Youngeun Kwon <[email protected]>

* add ref

Signed-off-by: Youngeun Kwon <[email protected]>

* add related tests

Signed-off-by: Youngeun Kwon <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Youngeun Kwon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
add max_t for KV

Signed-off-by: Charlene Yang <[email protected]>
* Add util functions to attn_mask_type

Signed-off-by: Reese Wang <[email protected]>

* Add util functions to qkv_layout

Signed-off-by: Reese Wang <[email protected]>

* Fix THD cross reference code

Signed-off-by: Reese Wang <[email protected]>

* Remove explicit segment_pad, encoding it to segment_ids

Signed-off-by: Reese Wang <[email protected]>

* Add jax.jit, replace _token with segment_ids, rename bias shape enum

Signed-off-by: Reese Wang <[email protected]>

* Add comment for make_mask

Signed-off-by: Reese Wang <[email protected]>

* Clean code

Signed-off-by: Reese Wang <[email protected]>

* Add doc strings for the added functions

Signed-off-by: Reese Wang <[email protected]>

* Remove cache for fa deterministic which causes UT failed

Signed-off-by: Reese Wang <[email protected]>

* Rename fixture to avoid conflict

Signed-off-by: Reese Wang <[email protected]>

---------

Signed-off-by: Reese Wang <[email protected]>
@pull pull bot added the ⤵️ pull label Dec 17, 2024
@pull pull bot merged commit 7f5c784 into phu0ngng:main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants