Deprecated parent constructor must not be called

phpstan · Jan 21, 2025 · 8b88b5f · 8b88b5f
1 parent 02277ce
commit 8b88b5f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Rules/Classes/RequireParentConstructCallRule.php b/src/Rules/Classes/RequireParentConstructCallRule.php
@@ -113,6 +113,7 @@ private function getParentConstructorClass($classReflection)
 					&& $constructor->getDeclaringClass()->getName() === $classReflection->getParentClass()->getName()
 					&& !$constructor->isAbstract()
 					&& !$constructor->isPrivate()
+					&& !$constructor->isDeprecated()
 				) || (
 					$constructorWithClassName !== null
 					&& $constructorWithClassName->getDeclaringClass()->getName() === $classReflection->getParentClass()->getName()

diff --git a/tests/Rules/Classes/data/call-to-parent-constructor.php b/tests/Rules/Classes/data/call-to-parent-constructor.php
@@ -181,3 +181,22 @@ public function __construct()
 	}
 
 }
+
+class DeprecatedConstructor
+{
+	/** @deprecated */
+	public function __construct()
+	{
+
+	}
+
+}
+
+class ExtendsDeprecatedConstructor extends DeprecatedConstructor
+{
+	public function __construct()
+	{
+		// should not call deprecated parent
+	}
+
+}