Fix ImpossibleCheckTypeFunctionCallRule for is_subclass
and is_a
#3788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved strategy for #3404
The main idea is that
always true
error can always be reported if the second param is a Constant class-string (or union of them).I included a non regression test from
#3404 (comment)
Closes phpstan/phpstan#3979
Closes phpstan/phpstan#8464