Implement OpenSslEncryptParameterOutTypeExtension
#3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
openssl-encrypt
branch
2 times, most recently
from
7394404 to
1663a9f
Compare
jack-worman
reviewed
Dec 22, 2024
paulbalandan
force-pushed
the
openssl-encrypt
branch
from
1663a9f to
0b93292
Compare
paulbalandan
changed the title
$tag of openssl_encrypt()OpenSslEncryptParameterOutTypeExtension
paulbalandan
force-pushed
the
openssl-encrypt
branch
2 times, most recently
from
4a82c99 to
e22aae5
Compare
paulbalandan
force-pushed
the
openssl-encrypt
branch
from
e22aae5 to
d1bad9e
Compare
|
This pull request has been marked as ready for review. |
paulbalandan
force-pushed
the
openssl-encrypt
branch
from
d1bad9e to
35b4a9d
Compare
staabm
reviewed
Jan 7, 2025
| return null; | ||
| } | ||
|
|
||
| $cipherType = current($scope->getType($cipherArg->value)->getConstantStrings()); |
There was a problem hiding this comment.
why do you only work on the first cipher type
There was a problem hiding this comment.
Thanks, I just realised you can do unions of literal strings. Updated the code to check all cases.
paulbalandan
force-pushed
the
openssl-encrypt
branch
from
35b4a9d to
b56032b
Compare
paulbalandan
force-pushed
the
openssl-encrypt
branch
from
b56032b to
430dfeb
Compare
staabm
reviewed
Jan 7, 2025
|
|
||
| $cipherType = $scope->getType($cipherArg->value); | ||
|
|
||
| return TypeTraverser::map($cipherType, static function (Type $type, callable $traverse): Type { |
There was a problem hiding this comment.
I don't think you need the TypeTraverser here. Couldn't you just iterate over getConstantStrings()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://www.php.net/manual/en/function.openssl-encrypt.php