Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on MethodCallableNode on do while #3752

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Fix crash on MethodCallableNode on do while #3752

wants to merge 1 commit into from
+32 −0

Conversation

samsonasik
Copy link
Contributor

@samsonasik
Copy link
Contributor Author

Ready to merge 👍

ondrejmirtes
ondrejmirtes requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. MethodCallableNode is not the only one with this problem. There's also FunctionCallableNode, InstantiationCallableNode, StaticMethodCallableNode. Please reproduce and fix issues with them too.
  2. Crashing examples have regression tests in AnalyserIntegrationTest, not in a specific rule. Because we're not fixing an error in a specific rule.
  3. Printing of custom nodes is fixed by adding a method on PHPStan\Node\Printer\Printer, not by modifying ExprPrinter.

Thanks.

@samsonasik
Copy link
Contributor Author

I will try

@samsonasik samsonasik mentioned this pull request Dec 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash on first class callable as conditional do while
2 participants
@samsonasik @ondrejmirtes