Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-8038: DOM extension reflection version is incorrect #17702

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −5
Open

Fix GH-8038: DOM extension reflection version is incorrect #17702

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fee13f0
Fix GH-8038: DOM extension reflection version is incorrect
cmb69 Feb 4, 2025
b0bd20e
Use ZEND_MODULE_API_NO instead of PHP_VERSION for BC
cmb69 Feb 4, 2025
e5e6a34
need a string
cmb69 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ext/dom/php_dom.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@ extern zend_module_entry dom_module_entry;
#include "xpath_callbacks.h"
#include "zend_exceptions.h"
#include "dom_ce.h"
/* DOM API_VERSION, please bump it up, if you change anything in the API
therefore it's easier for the script-programmers to check, what's working how
Can be checked with phpversion("dom");
*/
#define DOM_API_VERSION "20031129"

#define PHP_DOM_STRINGIFY(x) #x
#define PHP_DOM_TOSTRING(x) PHP_DOM_STRINGIFY(x)
#define DOM_API_VERSION PHP_DOM_TOSTRING(ZEND_MODULE_API_NO)

/* Define a custom type for iterating using an unused nodetype */
#define DOM_NODESET XML_XINCLUDE_START

Expand Down