[Rails] Explain how to render without a view context #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjanssen
force-pushed
the
rails-rendering-out-of-context
branch
4 times, most recently
from
1ac002c to
2bafbad
Compare
andrewjanssen
force-pushed
the
rails-rendering-out-of-context
branch
from
2bafbad to
48ddac8
Compare
joeldrapper
reviewed
Dec 4, 2024
joeldrapper
reviewed
Dec 4, 2024
| fake_rack_request = Rack::MockRequest.env_for("http://localhost", method: :get) | ||
| controller.request = ActionDispatch::Request.new(fake_rack_request) | ||
| html = controller.render_to_string(component, layout: false) | ||
| HelloMailer.with(html:).hello_email.deliver_now |
There was a problem hiding this comment.
Unless you need to access Rails’ view helpers, another way to render to HTML is to call it. html = component.call I’m not sure how Turbo handles controller-less rendering when you pass a renderable: (see above) but I wonder if looking into this might reveal a cleaner way to get a rendering context without a controller.
|
@andrewjanssen thanks for the PR. I left a couple of comments. I’m going to do a little research to see if there’s any way we can improve on this. Totally agree we need to cover it in the docs. |
Co-authored-by: Joel Drapper <[email protected]> Signed-off-by: Janssen <[email protected]>
|
You're welcome! Yes, it would be nice to avoid this fake object approach. Hard for me to know if this complexity could be pushed into phlex-rails or if that would be detrimental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to migrate an existing project to Phlex. But when moving my AR-callback-driven Turbo Stream renders, I hit exceptions and confusement. This PR will help others avoid the investigation that I did to learn how to render from AR callbacks, background jobs, etc.