Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Translate module and add related specs #96

Closed
wants to merge 2 commits into from

Conversation

stephannv
Copy link
Contributor

@stephannv stephannv commented Apr 28, 2023

Add tests to fix implemented here: #101

And replicate behavior for Translate module.

I think Translate module should have a t alias to translate method, so we can have only one module related to translation. But I just followed the current module organization and replicated the behavior.

@stephannv stephannv force-pushed the fix/translate_helper branch from e9ec441 to 6467284 Compare April 28, 2023 18:20
@stephannv
Copy link
Contributor Author

stephannv commented Apr 28, 2023

This test should fail even when the issue is fixed because allow(I18n).to receive(:translate).with("temp.translation_key") , we do not know what is the prefix before ".translation_key" because we are using a temp class without path.
But the error will be different.

@stephannv stephannv force-pushed the fix/translate_helper branch from 6467284 to 0f5f5e5 Compare February 8, 2024 18:34
@stephannv stephannv changed the title Add failing test about translate lazy lookup Fix Translate module and add related specs Feb 8, 2024
@stephannv
Copy link
Contributor Author

@joeldrapper I added some specs in this old PR and fixed Translate module to use translation path too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants