Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved on script with aria2c #93

Merged
merged 3 commits into from
Mar 30, 2019
Merged

improved on script with aria2c #93

merged 3 commits into from
Mar 30, 2019

Conversation

albertfougy
Copy link
Contributor

Screen Shot 2019-03-27 at 9 01 53 PM
#92 and #88 issues are squashed with the aria2c tool.

@philipmat
Copy link
Owner

That looks pretty awesome (also yay VSCode!)

Can we make it so that if the computer doesn't have aria2c installed, we fall back on wget?

@albertfougy
Copy link
Contributor Author

wgetandAria2c-conditional
w/ conditional provided client does not have aria2c installed.

Screen Shot 2019-03-29 at 5 08 43 PM
w/ wget exclusive of aria2c

Besides adding the "fallback" conditional for wget.

  1. refactored deprecated string interpolation
  2. added shebang
  3. split long statements in a couple of places
  4. added another flag for wget to show progress from left to right

@philipmat philipmat merged commit 434bed9 into philipmat:master Mar 30, 2019
@philipmat
Copy link
Owner

Thank you very much for making the code more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertfougy @philipmat