Merge pull request #14 from phi-rakib/bugfix/model-observers-deleting…

…-is-not-working

Bugfix/model observers deleting is not working

app/Http/Controllers/AccountController.php

@@ -45,6 +45,9 @@ public function destroy(Account $account)
     {
         Gate::authorize('delete', $account);
 
+        $account->deleted_by = auth()->id();
+        $account->save();
+
         $account->delete(); // soft delete
 
         return response()->json(['message' => 'Account deleted successfully'], 204);

app/Http/Controllers/DepositController.php

@@ -40,6 +40,9 @@ public function destroy(Deposit $deposit)
     {
         Gate::authorize('delete', $deposit);
 
+        $deposit->deleted_by = auth()->id();
+        $deposit->save();
+
         $deposit->delete();
 
         return response()->json(['message' => 'Deposited amount deleted'], 204);

app/Observers/AccountObserver.php

@@ -16,9 +16,4 @@ public function updating(Account $account)
     {
         $account->updated_by = auth()->id();
     }
-
-    public function deleting(Account $account): void
-    {
-        $account->deleted_by = auth()->id();
-    }
 }

app/Observers/DepositObserver.php

@@ -15,9 +15,4 @@ public function updating(Deposit $deposit)
     {
         $deposit->updated_by = auth()->id();
     }
-
-    public function deleting(Deposit $deposit)
-    {
-        $deposit->deleted_by = auth()->id();
-    }
 }

tests/Feature/AccountTest.php

@@ -75,6 +75,7 @@ public function test_user_can_delete_an_account()
 
         $this->assertSoftDeleted('accounts', [
             'id' => $account->id,
+            'deleted_by' => $this->user->id,
         ]);
     }
 

tests/Feature/DepositTest.php

@@ -78,6 +78,7 @@ public function test_user_can_delete_deposit()
 
         $this->assertSoftDeleted('deposits', [
             'id' => $deposit->id,
+            'deleted_by' => $this->user->id,
         ]);
     }