Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion benchmark examples and recover inspector extension #17124

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

guillep
Copy link
Member

@guillep guillep commented Sep 18, 2024

The completion benchmark extensions were lost in Pharo 10.
Recover them and do a pass on the comments.

@Ducasse
Copy link
Member

Ducasse commented Sep 18, 2024

Broken tests are not related.

@Ducasse Ducasse merged commit d84197b into pharo-project:Pharo13 Sep 18, 2024
1 of 2 checks passed
@MarcusDenker
Copy link
Member

The PR leads to #testNoUncategorizedMethods failing.

I added an issue tracker entry: #17128

(the test will now fail for all PRs until it is fixed)

@Ducasse
Copy link
Member

Ducasse commented Sep 18, 2024

Again this super stupid logic that we generate as yet unclassified.
What a bad idea. Now it was not fun to be forced to recover code in Pharo 90 because we removed "dead code" that was not dead and "lost" the inspector extensions.
This is always like that we migrate but we do not care about things that we do not use
and then we lose really nice things. Here it was the tool to evaluate completion configurations.

@hernanmd
Copy link
Member

Again this super stupid logic that we generate as yet unclassified. What a bad idea. Now it was not fun to be forced to recover code in Pharo 90 because we removed "dead code" that was not dead and "lost" the inspector extensions. This is always like that we migrate but we do not care about things that we do not use and then we lose really nice things. Here it was the tool to evaluate completion configurations.

What I find amazing is that the CI "fails" because of a missing protocol assignment. To me, it sounds pedantic and I think CI should fail for important failures, not because of uncategorized methods.

I pushed a fix 2 weeks ago hpi-swa/smalltalkCI#660 (not yet integrated) for which I had to make archeological editions (Pharo 90) in visual-studio code. Not fun at all

@guillep guillep deleted the completion-fix branch September 19, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants