Add Slack to Owners Page (Proof of Concept, do not land)

.arcconfig

@@ -1,5 +1,5 @@
 {
-  "phabricator.uri": "https://secure.phabricator.com/",
+  "phabricator.uri": "https://phabricator.robinhood.com/",
   "load": ["src/"],
   "history.immutable": false
 }

src/__phutil_library_map__.php

@@ -542,6 +542,7 @@
     'DifferentialDiffViewController' => 'applications/differential/controller/DifferentialDiffViewController.php',
     'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php',
     'DifferentialDraftField' => 'applications/differential/customfield/DifferentialDraftField.php',
+    'DifferentialExactResponsibleViewerFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactResponsibleViewerFunctionDatasource.php',
     'DifferentialExactUserFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php',
     'DifferentialFieldParseException' => 'applications/differential/exception/DifferentialFieldParseException.php',
     'DifferentialFieldValidationException' => 'applications/differential/exception/DifferentialFieldValidationException.php',
@@ -5766,6 +5767,7 @@
     'PhutilRemarkupCodeBlockRule' => 'infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php',
     'PhutilRemarkupDefaultBlockRule' => 'infrastructure/markup/blockrule/PhutilRemarkupDefaultBlockRule.php',
     'PhutilRemarkupDelRule' => 'infrastructure/markup/markuprule/PhutilRemarkupDelRule.php',
+    'PhutilRemarkupDisclosureRule' => 'infrastructure/markup/markuprule/PhutilRemarkupDisclosureRule.php',
     'PhutilRemarkupDocumentLinkRule' => 'infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php',
     'PhutilRemarkupEngine' => 'infrastructure/markup/remarkup/PhutilRemarkupEngine.php',
     'PhutilRemarkupEngineTestCase' => 'infrastructure/markup/remarkup/__tests__/PhutilRemarkupEngineTestCase.php',
@@ -6661,6 +6663,7 @@
     'DifferentialDiffViewController' => 'DifferentialController',
     'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'DoorkeeperFeedStoryPublisher',
     'DifferentialDraftField' => 'DifferentialCoreCustomField',
+    'DifferentialExactResponsibleViewerFunctionDatasource' => 'PhabricatorTypeaheadDatasource',
     'DifferentialExactUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DifferentialFieldParseException' => 'Exception',
     'DifferentialFieldValidationException' => 'Exception',
@@ -12767,6 +12770,7 @@
     'PhutilRemarkupCodeBlockRule' => 'PhutilRemarkupBlockRule',
     'PhutilRemarkupDefaultBlockRule' => 'PhutilRemarkupBlockRule',
     'PhutilRemarkupDelRule' => 'PhutilRemarkupRule',
+    'PhutilRemarkupDisclosureRule' => 'PhutilRemarkupRule',
     'PhutilRemarkupDocumentLinkRule' => 'PhutilRemarkupRule',
     'PhutilRemarkupEngine' => 'PhutilMarkupEngine',
     'PhutilRemarkupEngineTestCase' => 'PhutilTestCase',

src/applications/auth/controller/PhabricatorAuthRegisterController.php

@@ -198,7 +198,7 @@ public function handleRequest(AphrontRequest $request) {
       ->setDefaultUsername($default_username)
       ->setDefaultEmail($default_email)
       ->setDefaultRealName($default_realname)
-      ->setCanEditUsername(true)
+      ->setCanEditUsername(($default_username === null))
       ->setCanEditEmail(($default_email === null))
       ->setCanEditRealName(true)
       ->setShouldVerifyEmail(false);

src/applications/differential/editor/DifferentialRevisionEditEngine.php

@@ -200,7 +200,8 @@ protected function buildCustomEditFields($object) {
       $author_field->setCommentActionLabel(pht('Foist Upon'));
     }
 
-    $fields[] = $author_field;
+    // DEVX-2064
+    // $fields[] = $author_field;
 
     $fields[] = id(new PhabricatorRemarkupEditField())
       ->setKey(DifferentialRevisionSummaryTransaction::EDITKEY)

src/applications/differential/engineextension/DifferentialReviewersSearchEngineAttachment.php

@@ -13,10 +13,12 @@ public function getAttachmentDescription() {
 
   public function willLoadAttachmentData($query, $spec) {
     $query->needReviewers(true);
+    $query->needActiveDiffs(true);
   }
 
   public function getAttachmentForObject($object, $data, $spec) {
     $reviewers = $object->getReviewers();
+    $diff_phid = $object->getActiveDiff()->getPHID();
 
     $status_blocking = DifferentialReviewerStatus::STATUS_BLOCKING;
 
@@ -30,6 +32,7 @@ public function getAttachmentForObject($object, $data, $spec) {
         'status' => $status,
         'isBlocking' => $is_blocking,
         'actorPHID' => $reviewer->getLastActorPHID(),
+        'isCurrentAction' => $reviewer->isCurrentAction($diff_phid),
       );
     }
 

src/applications/differential/field/DifferentialTagsCommitMessageField.php

@@ -22,7 +22,7 @@ public function getFieldAliases() {
   }
 
   public function isTemplateField() {
-    return false;
+    return true;
   }
 
   public function parseFieldValue($value) {

src/applications/differential/query/DifferentialRevisionSearchEngine.php

@@ -113,13 +113,13 @@ protected function buildCustomSearchFields() {
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Modified After'))
         ->setKey('modifiedStart')
-        ->setIsHidden(true)
+        ->setIsHidden(false)
         ->setDescription(
           pht('Find revisions modified at or after a particular time.')),
       id(new PhabricatorSearchDateField())
         ->setLabel(pht('Modified Before'))
         ->setKey('modifiedEnd')
-        ->setIsHidden(true)
+        ->setIsHidden(false)
         ->setDescription(
           pht('Find revisions modified at or before a particular time.')),
       id(new PhabricatorSearchStringListField())

src/applications/differential/storage/DifferentialReviewer.php

@@ -134,7 +134,7 @@ public function isAccepted($diff_phid) {
     return false;
   }
 
-  private function isCurrentAction($diff_phid) {
+  public function isCurrentAction($diff_phid) {
     if (!$diff_phid) {
       return true;
     }

src/applications/differential/storage/DifferentialRevision.php

@@ -223,6 +223,11 @@ public function canReviewerForceAccept(
     PhabricatorUser $viewer,
     DifferentialReviewer $reviewer) {
 
+    // NOTE(joel.jeske)
+    // We do not want to support force-acceptance if owning a parent package
+    // All ownership rules should be declared in OWNERS.toml files
+    return false;
+
     if (!$reviewer->isPackage()) {
       return false;
     }

src/applications/differential/typeahead/DifferentialExactResponsibleViewerFunctionDatasource.php

@@ -0,0 +1,73 @@
+<?php
+
+final class DifferentialExactResponsibleViewerFunctionDatasource
+  extends PhabricatorTypeaheadDatasource {
+
+  public function getBrowseTitle() {
+    return pht('Browse Exact Viewer');
+  }
+
+  public function getPlaceholderText() {
+    return pht('Type exact-viewer()...');
+  }
+
+  public function getDatasourceApplicationClass() {
+    return 'PhabricatorPeopleApplication';
+  }
+
+  public function getDatasourceFunctions() {
+    return array(
+      'exact-viewer' => array(
+        'name' => pht('Exact Current Viewer'),
+        'summary' => pht('Results matching the current viewing user exactly.'),
+        'description' => pht(
+          'Find revisions the current viewer is responsible for, exactly,'.
+          'and not include those through their projects or packages. '),
+        ),
+    );
+  }
+
+  public function loadResults() {
+    if ($this->getViewer()->getPHID()) {
+      $results = array($this->renderViewerFunctionToken());
+    } else {
+      $results = array();
+    }
+
+    return $this->filterResultsAgainstTokens($results);
+  }
+
+  protected function canEvaluateFunction($function) {
+    if (!$this->getViewer()->getPHID()) {
+      return false;
+    }
+
+    return parent::canEvaluateFunction($function);
+  }
+
+  protected function evaluateFunction($function, array $argv_list) {
+    $results = array();
+    foreach ($argv_list as $argv) {
+      $results[] = $this->getViewer()->getPHID();
+    }
+    return $results;
+  }
+
+  public function renderFunctionTokens($function, array $argv_list) {
+    $tokens = array();
+    foreach ($argv_list as $argv) {
+      $tokens[] = PhabricatorTypeaheadTokenView::newFromTypeaheadResult(
+        $this->renderViewerFunctionToken());
+    }
+    return $tokens;
+  }
+
+  private function renderViewerFunctionToken() {
+    return $this->newFunctionResult()
+      ->setName(pht('Exact: Current Viewer'))
+      ->setPHID('exact-viewer()')
+      ->setIcon('fa-user')
+      ->setUnique(true);
+  }
+
+}

src/applications/differential/typeahead/DifferentialResponsibleDatasource.php

@@ -18,6 +18,7 @@ public function getDatasourceApplicationClass() {
   public function getComponentDatasources() {
     return array(
       new DifferentialResponsibleUserDatasource(),
+      new DifferentialExactResponsibleViewerFunctionDatasource(),
       new DifferentialResponsibleViewerFunctionDatasource(),
       new DifferentialExactUserFunctionDatasource(),
       new PhabricatorProjectDatasource(),

src/applications/differential/view/DifferentialReviewersView.php

@@ -166,11 +166,14 @@ public function render() {
           null,
           $diff->getPHID()));
 
-      if ($reviewer->isPackage()) {
-        if (!$reviewer->getChangesets()) {
-          $item->setNote(pht('(Owns No Changed Paths)'));
-        }
-      }
+      // With advanced Ownership in OWNERS.toml, this is message is
+      // no longer accurate.
+      //
+      // if ($reviewer->isPackage()) {
+      //   if (!$reviewer->getChangesets()) {
+      //     $item->setNote(pht('(Owns No Changed Paths)'));
+      //   }
+      // }
 
       if ($handle->hasCapabilities()) {
         if (!$handle->hasViewCapability($diff)) {

src/applications/files/query/PhabricatorFileQuery.php

@@ -183,6 +183,13 @@ protected function loadPage() {
         $always_visible = true;
       }
 
+      // DEVX-2087: skip file policy check if it is PUBLIC or ALL_USERS
+      $file_view_policy = $file->getViewPolicy();
+      if ($file_view_policy == PhabricatorPolicies::POLICY_PUBLIC ||
+          $file_view_policy == PhabricatorPolicies::POLICY_USER) {
+        $always_visible = true;
+      }
+
       if ($always_visible) {
         // We just treat these files as though they aren't attached to
         // anything. This saves a query in common cases when we're loading

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

@@ -593,9 +593,14 @@ private function sendToTarget(
 
     $unit_messages = $request->getValue('unit', array());
     foreach ($unit_messages as $unit) {
-      $save[] = HarbormasterBuildUnitMessage::newFromDictionary(
+      $bu_message = HarbormasterBuildUnitMessage::newFromDictionary(
         $build_target,
         $unit);
+      // DEVX-2087:only save to db for failed test case and coverage information
+      if (($bu_message->getResult() == ArcanistUnitTestResult::RESULT_FAIL) ||
+          ($bu_message->getProperty('coverage') != null)) {
+        $save[] = $bu_message;
+      }
     }
 
     $save[] = HarbormasterBuildMessage::initializeNewMessage($viewer)

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

@@ -56,34 +56,73 @@ public function execute(
       'vurisprintf',
       $settings['uri'],
       $variables);
-
     $method = nonempty(idx($settings, 'method'), 'POST');
 
-    $future = id(new HTTPSFuture($uri))
-      ->setMethod($method)
-      ->setTimeout(60);
-
-    $credential_phid = $this->getSetting('credential');
-    if ($credential_phid) {
-      $key = PassphrasePasswordKey::loadFromPHID(
-        $credential_phid,
-        $viewer);
-      $future->setHTTPBasicAuthCredentials(
-        $key->getUsernameEnvelope()->openEnvelope(),
-        $key->getPasswordEnvelope());
+    $sleepDuration = 30;
+    $retry = 0;
+    while (true) {
+      $future = id(new HTTPSFuture($uri))
+        ->setMethod($method)
+        ->setTimeout(60);
+
+      $credential_phid = $this->getSetting('credential');
+      if ($credential_phid) {
+        $key = PassphrasePasswordKey::loadFromPHID(
+          $credential_phid,
+          $viewer);
+        $future->setHTTPBasicAuthCredentials(
+          $key->getUsernameEnvelope()->openEnvelope(),
+          $key->getPasswordEnvelope());
+      }
+
+      $this->resolveFutures(
+        $build,
+        $build_target,
+        array($future));
+
+      $this->logHTTPResponse($build, $build_target, $future, $uri);
+
+      list($status) = $future->resolve();
+      try {
+        $this->emitBuildResultMetric($build->getBuildPlan()->getID(), $status->getStatusCode(), $retry);
+      } catch (Exception $e) {
+        echo 'Caught exception while sending Jenkins metrics to statsd: ',  $e->getMessage(), "\n";
+      }
+      if (!$status->isError()) {
+        return;
+      }
+      if ($retry == 2) {
+        throw new HarbormasterBuildFailureException();
+      }
+      sleep($sleepDuration);
+      $sleepDuration *= 2;
+      $retry++;
     }
+  }
 
-    $this->resolveFutures(
-      $build,
-      $build_target,
-      array($future));
-
-    $this->logHTTPResponse($build, $build_target, $future, $uri);
-
-    list($status) = $future->resolve();
-    if ($status->isError()) {
-      throw new HarbormasterBuildFailureException();
+  public function emitBuildResultMetric($plan, $status, $retry) {
+    $template = 'echo "phabricator_build_result_total:1|c|#plan:$plan,status:$status,retry:$retry" | nc -w 3 -vu apollo-statsd.integration-tests.svc.cluster.local 8125';
+    $vars = array(
+      '$plan' => $plan,
+      '$status' => $status,
+      '$retry' => $retry,
+    );
+    $command = strtr($template, $vars);
+    echo $command;
+
+    $metrics_retry = 0;
+    $retval = 0;
+    $output = null;
+    while ($metrics_retry < 3) {
+      exec($command, $output, $retval);
+      if ($retval == 0) {
+        return;
+      }
+      $metrics_retry++;
+      sleep(1);
     }
+    echo "Got error code $retval when sending metrics to statsd with output:\n";
+    print_r($output);
   }
 
   public function getFieldSpecifications() {
@@ -112,5 +151,4 @@ public function getFieldSpecifications() {
   public function supportsWaitForMessage() {
     return true;
   }
-
 }

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

@@ -196,6 +196,7 @@ public function getFieldValuesForConduit() {
       'buildTargetPHID' => $this->getBuildTargetPHID(),
       'artifactType' => $this->getArtifactType(),
       'artifactKey' => $this->getArtifactKey(),
+      'artifactData' => $this->artifactData,
       'isReleased' => (bool)$this->getIsReleased(),
     );
   }

src/applications/home/view/PHUIHomeView.php

@@ -86,7 +86,8 @@ private function buildRevisionPanel() {
     $panel = $this->newQueryPanel()
       ->setName(pht('Active Revisions'))
       ->setProperty('class', 'DifferentialRevisionSearchEngine')
-      ->setProperty('key', 'active');
+      ->setProperty('key', 'active')
+      ->setProperty('modifiedStart', '30 days ago');
 
     return $this->renderPanel($panel);
   }

src/applications/owners/controller/PhabricatorOwnersDetailController.php

@@ -220,8 +220,18 @@ private function buildPackageDetailView(
       $ignored = phutil_tag('em', array(), pht('None'));
     }
 
+
+
     $view->addProperty(pht('Ignored Attributes'), $ignored);
 
+    // Add Slack Channel Field
+    $slack_channel = $package->getSlackChannel();
+    if ($slack_channel) {
+      $view->addProperty(pht('Slack Channel'), $slack_channel);
+    } else {
+      $view->addProperty(pht('Slack Channel'), phutil_tag('em', array(), pht('None')));
+    }
+
     $description = $package->getDescription();
     if (strlen($description)) {
       $description = new PHUIRemarkupView($viewer, $description);