-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fixes bug, adds unittest to prevent, adds exception handling, and include CI #8
Conversation
… and exception handling for passing empty string and invalid ticker symbol
…ling, adds unittests, and includeds contin. integration tests for Windows, Linux, OSX.
…od-morning into urlFix_linwoodError
commit c1fcdae Merge: fde97ac fd73447 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 14:08:59 2017 -0400 Merge branch 'urlFix_linwoodError' of https://github.com/linwoodc3/good-morning into urlFix_linwoodError commit fde97ac Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:28:18 2017 -0400 Fixes petercerno#6 and petercerno#7 url problems, adds exception handling, adds unittests, and includeds contin. integration tests for Windows, Linux, OSX. commit fd73447 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 13:36:25 2017 -0400 Fixing the travis ci build. # 17 commit f58f591 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 13:17:00 2017 -0400 Fixing the travis ci build. # 16 commit fcc539a Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 13:06:44 2017 -0400 Fixing the travis ci build. # 15 commit 6fc4e9f Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:55:46 2017 -0400 Fixing the travis ci build. # 14 commit 6d04c78 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:40:49 2017 -0400 Fixing the travis ci build. # 13 commit a280acf Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:20:20 2017 -0400 Fixing the travis ci build. # 12 commit 57abfd1 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:12:17 2017 -0400 Fixing the travis ci build. # 11 commit 536ec5d Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:51:13 2017 -0400 Fixing the travis ci build. # 9 commit 7e8a6d7 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:39:51 2017 -0400 Fixing the travis ci build. # 8 commit 7e95db7 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:33:16 2017 -0400 Fixing the travis ci build. # 7 commit d97535a Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:23:15 2017 -0400 Fixing the travis ci build. # 6 commit 7b48720 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:19:08 2017 -0400 Fixing the travis ci build. # 5 commit 64f6f12 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:09:12 2017 -0400 Fixing the travis ci build. # 4 commit c8501e9 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:56:42 2017 -0400 Fixing the travis ci build. # 3 commit 7853d38 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:50:37 2017 -0400 Fixing the travis ci build. # 2 commit 9a00fbf Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:47:04 2017 -0400 Fixing the travis ci build. commit 3df0634 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:28:18 2017 -0400 Fixes petercerno#6 and petercerno#7 url problems. Also adds unit test and exception handling for passing empty string and invalid ticker symbol
commit c1fcdae Merge: fde97ac fd73447 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 14:08:59 2017 -0400 Merge branch 'urlFix_linwoodError' of https://github.com/linwoodc3/good-morning into urlFix_linwoodError commit fde97ac Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:28:18 2017 -0400 Fixes petercerno#6 and petercerno#7 url problems, adds exception handling, adds unittests, and includeds contin. integration tests for Windows, Linux, OSX. commit fd73447 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 13:36:25 2017 -0400 Fixing the travis ci build. # 17 commit f58f591 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 13:17:00 2017 -0400 Fixing the travis ci build. # 16 commit fcc539a Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 13:06:44 2017 -0400 Fixing the travis ci build. # 15 commit 6fc4e9f Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:55:46 2017 -0400 Fixing the travis ci build. # 14 commit 6d04c78 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:40:49 2017 -0400 Fixing the travis ci build. # 13 commit a280acf Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:20:20 2017 -0400 Fixing the travis ci build. # 12 commit 57abfd1 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 12:12:17 2017 -0400 Fixing the travis ci build. # 11 commit 536ec5d Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:51:13 2017 -0400 Fixing the travis ci build. # 9 commit 7e8a6d7 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:39:51 2017 -0400 Fixing the travis ci build. # 8 commit 7e95db7 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:33:16 2017 -0400 Fixing the travis ci build. # 7 commit d97535a Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:23:15 2017 -0400 Fixing the travis ci build. # 6 commit 7b48720 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:19:08 2017 -0400 Fixing the travis ci build. # 5 commit 64f6f12 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 11:09:12 2017 -0400 Fixing the travis ci build. # 4 commit c8501e9 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:56:42 2017 -0400 Fixing the travis ci build. # 3 commit 7853d38 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:50:37 2017 -0400 Fixing the travis ci build. # 2 commit 9a00fbf Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:47:04 2017 -0400 Fixing the travis ci build. commit 3df0634 Author: Linwood Creekmore III <[email protected]> Date: Sun Jul 23 10:28:18 2017 -0400 Fixes petercerno#6 and petercerno#7 url problems. Also adds unit test and exception handling for passing empty string and invalid ticker symbol
I really appreciate your contribution and your enthusiasm for the project. Unfortunately, I cannot accept your pull request in the current form (as it is a bundle of two independent changes). Would it be possible to create another pull request containing only the bug fix (and nothing else)? I do not want to add the CI code as it adds unnecessary complexity, i.e. I prefer to keep the code as simple as possible (without any distractions), and the library as small as possible. |
No unittests either? That will check to see if the url return has changed or not. |
And being transparent, the enthusiasm is around the utility of the code. I can use this library for "Buffett-style" security analysis, so, it helps me. :-) |
Ah, sorry, yes it is perfectly fine to add unit tests. Maybe add a small comment about how to run the unit tests (either in README, or the unit tests themselves). Thanks a lot! |
This is a bug fix to something I unknowingly causes in the merge request a month ago. The CI piece is trial and error so that's why there are so many. The code changes are minimal. More importantly, it fixes a bug likely causes by me and makes it so no one else can break good-morning.
To add CI to good-morning it only takes a few clicks:
Travis gives coverage for Linux and OSX; Appveyor gives coverage for Windows.
Now, when anyone does a pull request, the unit tests launch automatically, and if it doesn't pass, you know the pull request breaks
good-morning
.