-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support exdates and multiple events with the same UID #44
Open
jfrumar
wants to merge
7
commits into
peterbraden:master
Choose a base branch
from
jfrumar:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrumar
commented
Aug 4, 2014
- Factored out the dateParsing so that it can be reused to generate an array of EXDATE directives when they are provided in the ICS feed.
- Index VEVENTs by a GUID since the UIDs provided aren't always unique for each VEVENT. For example, you can create a recurring event in Google calendar, then modify future events based off the master, and they'll all have the same UID - the child events with modifications are distinguished by a RECURRENCE-ID.
jfrumar
changed the title
Support exdates
Support exdates and multiple events with the same UID
Aug 8, 2014
The tests aren't passing for me - any ideas?
|
They are fixed now? |
mreid1130
added a commit
to joinspoton/ical
that referenced
this pull request
Sep 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.