feat: convert relative urls to absolute #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-evans
reviewed
Mar 1, 2023
There was a problem hiding this comment.
This is great. Thank you!
Would you be willing to codify the test cases you have here?
https://github.com/mrtwnklr/workflow-tests/blob/main/DOCKERHUB_DESCRIPTION.md#test-cases
This project doesn't have unit tests yet because it wasn't really that necessary until now. I think readme-helper should really have unit tests, though.
Please put them under __test__. e.g., tests in find-comment action
And just remove --passWithNoTests here:
https://github.com/peter-evans/dockerhub-description/blob/main/package.json#L12
mrtwnklr
force-pushed
the
feat/convert_relative_urls_to_absolute
branch
from
d45762d to
0b49034
Compare
Now that you're asking, of course. |
mrtwnklr
force-pushed
the
feat/convert_relative_urls_to_absolute
branch
from
0b49034 to
0acae48
Compare
|
☑️ tests |
|
Please run |
mrtwnklr
force-pushed
the
feat/convert_relative_urls_to_absolute
branch
from
0acae48 to
64f19e6
Compare
|
sry, done |
peter-evans
approved these changes
Mar 5, 2023
peter-evans
added a commit
that referenced
this pull request
Mar 5, 2023
* feat: convert relative urls to absolute * test: add tests for conversion of relative urls Co-authored-by: Marty Winkler <[email protected]>
|
Released as |
|
Great! Maybe worth closing #41 ? |
|
I left a comment here: #41 (comment) I just want to check if the emoji feature is feasible or not before deciding whether to close. |
pascalberger
referenced
this pull request
in swissgrc/.github
Mar 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [peter-evans/dockerhub-description](https://togithub.com/peter-evans/dockerhub-description) | action | minor | `v3.1.2` -> `v3.3.0` | --- ### Release Notes <details> <summary>peter-evans/dockerhub-description</summary> ### [`v3.3.0`](https://togithub.com/peter-evans/dockerhub-description/releases/tag/v3.3.0): Docker Hub Description v3.3.0 [Compare Source](https://togithub.com/peter-evans/dockerhub-description/compare/v3.2.0...v3.3.0) #### What's Changed - feat: truncate content exceeding the byte limit by [@​peter-evans](https://togithub.com/peter-evans) in [https://github.com/peter-evans/dockerhub-description/pull/129](https://togithub.com/peter-evans/dockerhub-description/pull/129) - 2 dependency updates by [@​dependabot](https://togithub.com/dependabot) **Full Changelog**: peter-evans/dockerhub-description@v3.2.0...v3.3.0 ### [`v3.2.0`](https://togithub.com/peter-evans/dockerhub-description/releases/tag/v3.2.0): Docker Hub Description v3.2.0 [Compare Source](https://togithub.com/peter-evans/dockerhub-description/compare/v3.1.2...v3.2.0) #### What's Changed - feat: convert relative urls to absolute ([#​125](https://togithub.com/peter-evans/dockerhub-description/issues/125)) by [@​mrtwnklr](https://togithub.com/mrtwnklr) in [https://github.com/peter-evans/dockerhub-description/pull/126](https://togithub.com/peter-evans/dockerhub-description/pull/126) - 35 dependency updates by [@​dependabot](https://togithub.com/dependabot) #### New Contributors - [@​mrtwnklr](https://togithub.com/mrtwnklr) made their first contribution in [https://github.com/peter-evans/dockerhub-description/pull/125](https://togithub.com/peter-evans/dockerhub-description/pull/125) **Full Changelog**: peter-evans/dockerhub-description@v3.1.2...v3.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/swissgrc/.github). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuNyIsInVwZGF0ZWRJblZlciI6IjM0LjE1Ny4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin: see #41
Completion of relative urls is configurable with
enable-url-completion. Default isfalse.For known issues see changes in README.md
For test cases see: