Allow SVCB records to contain underscores in the name

peteeckel · Jan 20, 2025 · 5b1ebd3 · 5b1ebd3
1 parent 8d8aecc
commit 5b1ebd3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/using_netbox_dns.md b/docs/using_netbox_dns.md
@@ -651,7 +651,7 @@ Variable                            | Factory Default
 --------                            | ---------------
 `tolerate_underscores_in_labels`    | `False`
 `tolerate_characters_in_zone_labels`| `''`
-`tolerate_leading_underscore_types` | `["TXT", "SRV", "TLSA", "CNAME", "DNAME"]`
+`tolerate_leading_underscore_types` | `["TXT", "SRV", "SVCB", "TLSA", "CNAME", "DNAME"]`
 `tolerate_non_rfc1035_types`        | `[]`
 
 The settings can be set or overridden in the file `/opt/netbox/netbox/netbox/configuration.py` by defining new values in `PLUGINS_CONFIG` as follows:
@@ -662,7 +662,7 @@ PLUGINS_CONFIG = {
         ...
         'tolerate_underscores_in_labels': True,
         'tolerate_characters_in_zone_labels': "/",
-        'tolerate_leading_underscore_types': ["TXT", "SRV", "TLSA", "CNAME", "DNAME", "MX"]
+        'tolerate_leading_underscore_types': ["TXT", "SRV", "SVCB", "TLSA", "CNAME", "DNAME", "MX"]
         'tolerate_non_rfc1035_types': ["X25"]
     },
 }

diff --git a/netbox_dns/__init__.py b/netbox_dns/__init__.py
@@ -53,6 +53,7 @@ class DNSConfig(PluginConfig):
             RecordTypeChoices.CNAME,
             RecordTypeChoices.DNAME,
             RecordTypeChoices.SRV,
+            RecordTypeChoices.SVCB,
             RecordTypeChoices.TLSA,
             RecordTypeChoices.TXT,
         ],