Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dac workflow: move some inputs to secrets #12

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 21 additions & 25 deletions .github/workflows/dac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,30 +33,10 @@ on:
type: boolean
required: false
# auth:
username:
description: Username for basic authentication to the API server.
type: string
required: false
password:
description: Password for basic authentication to the API server.
type: string
required: false
token:
description: Bearer token for authentication to the API server.
type: string
required: false
provider:
description: External authentication provider identifier. (slug_id)
type: string
required: false
client-id:
description: Client ID used for robotic access when using external authentication provider.
type: string
required: false
client-secret:
description: Client Secret used for robotic access when using external authentication provider.
type: string
required: false
insecure-skip-tls-verify:
description: If true the server's certificate will not be checked for validity. This will make your HTTPS connections insecure.
type: string
Expand All @@ -76,6 +56,22 @@ on:
description: If present, dashboards will be deployed even if the projects are not consistent between the --project flag and the dashboards metadata (the latter has priority).
type: boolean
required: false
secrets:
username:
description: Username for basic authentication to the API server.
required: false
password:
description: Password for basic authentication to the API server.
required: false
token:
description: Bearer token for authentication to the API server.
required: false
client-id:
description: Client ID used for robotic access when using external authentication provider.
required: false
client-secret:
description: Client Secret used for robotic access when using external authentication provider.
required: false

jobs:
dac:
Expand Down Expand Up @@ -105,12 +101,12 @@ jobs:
uses: ./actions/login
with:
url: ${{ inputs.url }}
username: ${{ inputs.username }}
password: ${{ inputs.password }}
token: ${{ inputs.token }}
username: ${{ secrets.username }}
password: ${{ secrets.password }}
token: ${{ secrets.token }}
provider: ${{ inputs.provider }}
client-id: ${{ inputs.client-id }}
client-secret: ${{ inputs.client-secret }}
client-id: ${{ secrets.client-id }}
client-secret: ${{ secrets.client-secret }}
insecure-skip-tls-verify: ${{ inputs.insecure-skip-tls-verify }}

- name: Validate the dashboards
Expand Down
Loading