WIP better diff output

Signed-off-by: Antoine THEBAUD <[email protected]>

actions/diff_dashboards/action.yaml

@@ -29,24 +29,52 @@ runs:
           $([[ -n "${{ inputs.project }}" ]] && echo "--project ${{ inputs.project }}")
       shell: bash
 
-    - name: Upload diffs as artifacts
-      uses: actions/upload-artifact@v4
-      with:
-        name: dashboard-diffs
-        path: built/
-
-    - name: Post artifacts link to PR
+    - name: Post diffs as PR comments
       if: ${{ github.event_name == 'pull_request' }}
       uses: actions/github-script@v7
       with:
         script: |
-          const runId = process.env.GITHUB_RUN_ID;
-          const repoUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}`;
-          const artifactUrl = `${repoUrl}/actions/runs/${runId}`;
-          const commentBody = `### Dashboard diffs\nThe dashboard diffs can be downloaded from the [workflow artifacts](artifactUrl).`;
+          const fs = require('fs');
+          const path = require('path');
+
+          // Directory containing the diff files
+          const diffDir = './built';
+
+          // Filter files to include only those with a `.diff` extension
+          const diffFiles = fs.readdirSync(diffDir).filter(file => file.endsWith('.diff'));
+
+          if (diffFiles.length === 0) {
+            console.log('No diff files found to comment.');
+            return;
+          }
+
+          // Generate the PR comment with collapsible sections
+          let commentBody = `### Dashboard diffs\n\n`;
+          for (const file of diffFiles) {
+            const filePath = path.join(diffDir, file);
+            const diffContent = fs.readFileSync(filePath, 'utf-8').trim();
+
+            if (diffContent) {
+              // Include a collapsible section for non-empty diffs
+              commentBody += `
+            <details>
+            <summary>${file}</summary>
+
+            \`\`\`diff
+            ${diffContent}
+            \`\`\`
+            </details>\n\n
+              `;
+            } else {
+              // Add a plain "No change" message for empty diffs
+              commentBody += `- ${file}\nNo change\n`;
+            }
+          }
+
+          // Post the comment
           github.rest.issues.createComment({
             owner: context.repo.owner,
             repo: context.repo.repo,
             issue_number: context.issue.number,
-            body: commentBody.replace('artifactUrl', artifactUrl)
+            body: commentBody.trim() // Ensure no trailing newlines
           });

testdata/resources_folder/dashboard copy.json

@@ -0,0 +1,20 @@
+{
+  "kind": "Dashboard",
+  "metadata": {
+    "name": "nodeexporterfull",
+    "createdAt": "2024-12-04T15:08:03.737189012Z",
+    "updatedAt": "2024-12-04T15:08:03.737189012Z",
+    "version": 0,
+    "project": "perses"
+  },
+  "spec": {
+    "display": {
+      "name": "Emptyeeeee Dashboard"
+    },
+    "panels": {},
+    "layouts": [],
+    "variables": [],
+    "duration": "1h",
+    "refreshInterval": "0s"
+  }
+}

testdata/resources_folder/dashboard.json

@@ -9,7 +9,7 @@
   },
   "spec": {
     "display": {
-      "name": "Empty Dashboard"
+      "name": "Emptyeeeee Dashboard"
     },
     "panels": {},
     "layouts": [],