Improved power2 via furrr #15
Conversation
|
Automatic checks fail. Please review and correct your code. |
|
Still not working? |
|
Still not passing checks. Please check locally before pushing please. |
|
I have updated DESCRIPTION file importing I do not explicitly use |
|
You should check the package locally which will tell you what's wrong. |
R/simulations.R
Outdated
| seed = 1234 | ||
| )$pvalue | ||
| ) | ||
| progressr::handlers(progressr::handler_progress(format="[:bar] :percent :eta :message")) |
There was a problem hiding this comment.
The user defines these. Not us as package developers.
R/simulations.R
Outdated
| y <- furrr::future_map_dbl(1:xs, pbfun, .options = furrr::furrr_options(seed = TRUE)) | ||
| } | ||
|
|
||
| progressr::with_progress(pvalues <- fun(R)) |
There was a problem hiding this comment.
Same thing here.
In addition, fun is not a good naming convention, nor is dummy.
R/simulations.R
Outdated
|
|
||
| fun <- function(xs) { | ||
| p <- progressr::progressor(steps = xs) | ||
| pbfun <- function(dummy){ |
There was a problem hiding this comment.
pbfun is not evocative as a name either...
DESCRIPTION
Outdated
| @@ -54,7 +54,10 @@ Imports: | |||
| magrittr, | |||
| flipr, | |||
| cli, | |||
| withr | |||
| withr, | |||
| progress, | |||
There was a problem hiding this comment.
Where do you use the progress package?
There was a problem hiding this comment.
As commented before:
I have updated DESCRIPTION file importing
progressrandfurrr. However, checks report:Error: Error in loadNamespace(x) : there is no package called 'progress'I do not explicitly use
progress, should I add this package to "Imports" in DESCRIPTION file?
I solve errors by adding the progress package in DESCRIPTION file, but I do not use it explicitly.
I have modified
power2()usingfurrrfunctions, as mentioned in #11.