Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors and Updates #14

Closed
wants to merge 7 commits into from
Closed

Refactors and Updates #14

wants to merge 7 commits into from

Conversation

mobileoverlord
Copy link
Contributor

@mobileoverlord mobileoverlord commented May 15, 2024 •
edited
Loading

Refactors:

  • The Configurator module. Cleaned up the code paths, allows values to be defaulted / optional.
  • Do not shutdown the VM if errors, this allows the service to operate more friendly in Nerves distributions and allows for easier time grabbing error messages.
  • Make PERIDIO_CONFIG_FILE optional. If specified and parsed, values in this file will override ones provided in config.exs

Updates:

  • Reintroduced support for the IEx based remote console. This is useful when shipping on stock Nerves distributions which do not include enough userspace tooling like socat to support connecting using a getty.
  • Add config key remote_iex which when set to true will implement the iex version of the remote shell connection.
  • Added support for passing extra_args to fwup. Useful if you need to pass the --unsafe flag to fwup to use "unsafe" command execution in fwup conf files.
  • Added support for passing extra environment variables to decorate the environment which fwup is being executed within.
  • Added extra info messages to the console / journalctl output.
  • Made it easier to configure peridiod when being used as a dependency from within a Nerves based Application.

Testing and Integration:

  • peridiod can now be tested within docker including both style remote_console methods and firmware updates.
  • Updated docker buildx files to fix broken builds when using musl-c and muontrap.

Tested in staging and production.

@mobileoverlord
Refactor configurator
391eaa1 
* Prevent PERIDIO_CONFIG_FILE from stopping the VM to present a better error.
* Allow sane default values to be optional
* Allow the application to be configured via config.exs with overrides from PERIDIO_CONFIG_FILE
* Add remote_iex to enable the IEx remote console shell. If this is enabled, the shell will default to IEx
* remote_shell will continue to open a getty
* Allow setting fwup extra_args.
* Allow setting fwup env
@mobileoverlord
Allow passing extra_args and env to fwup
844a8bd
@mobileoverlord
Add openssl3 pkcs11 engine search paths
4267bba
@mobileoverlord
Refactor remote_console to support iex and getty
f5de06c
@mobileoverlord
Update docker support to fix broken builds when depending on musl-c
8509dd8
@mobileoverlord
Update readme
966881b
danielspofford
danielspofford previously approved these changes May 16, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@mobileoverlord mobileoverlord dismissed danielspofford’s stale review May 16, 2024 21:29

The merge-base changed after approval.

@mobileoverlord mobileoverlord deleted the js-updates branch May 16, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielspofford danielspofford danielspofford left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobileoverlord @danielspofford