add patch tunnels to device api #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontwong
force-pushed
the
jwong/eng-1573-implement-device-api-patch-tunnelstunnel_prn
branch
from
7fa6911 to
b5199c4
Compare
danielspofford
requested changes
May 3, 2024
There was a problem hiding this comment.
- Match style of "Configure a tunnel" above it.
- Same thing, look at style of how this shows up for configure a tunnel and match it.
- Full sentences here means period at end.
- Ignore this markup, I was going to say you need to also mark the
statefield itself (not just the overall body) as required, but I changed my mind. I actually think I will comment on the other PR and make sure the update succeeds even when asking to change nothing...
jasontwong
force-pushed
the
jwong/eng-1573-implement-device-api-patch-tunnelstunnel_prn
branch
from
b5199c4 to
e7f6a72
Compare
danielspofford
approved these changes
May 4, 2024
danielspofford
deleted the
jwong/eng-1573-implement-device-api-patch-tunnelstunnel_prn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.